Skip to content

[SyntaxParse] Fix the end location for CompositionTypeRepr #27024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2019
Merged

[SyntaxParse] Fix the end location for CompositionTypeRepr #27024

merged 1 commit into from
Sep 4, 2019

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Sep 4, 2019

The end loc should be the loc of the last token of the last type element.

CC: @davidungar

@rintaro rintaro requested a review from nkcsgexi September 4, 2019 19:01
@rintaro
Copy link
Member Author

rintaro commented Sep 4, 2019

@swift-ci Please smoke test

@rintaro
[SyntaxParse] Fix the end location for CompositionTypeRepr
9612f44 
The end loc should be the loc of the last token of the last type
element.
@rintaro rintaro force-pushed the syntaxparse-endloc-composition branch from 71c393a to 9612f44 Compare September 4, 2019 19:11
@rintaro
Copy link
Member Author

rintaro commented Sep 4, 2019

@swift-ci Please smoke test

@rintaro
Copy link
Member Author

rintaro commented Sep 4, 2019

@swift-ci Please smoke test Linux

nkcsgexi
nkcsgexi approved these changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rintaro rintaro merged commit 99c6521 into swiftlang:master Sep 4, 2019
rintaro added a commit to rintaro/swift that referenced this pull request Oct 14, 2019
@rintaro
Revert "Merge pull request swiftlang#27024 from rintaro/syntaxparse-e…
601c90d 
…ndloc-composition"

This reverts commit 99c6521, reversing
changes made to 3ddfcae.
rintaro added a commit to rintaro/swift that referenced this pull request Oct 14, 2019
@rintaro
Revert "Revert "Merge pull request swiftlang#27024 from rintaro/synta…
4b50c08 
…xparse-endloc-composition""

This reverts commit 601c90d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkcsgexi nkcsgexi nkcsgexi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rintaro @nkcsgexi