Skip to content

[ModuleInterfaces] Escape Type and Protocol when module-qualifying #27065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2019
Merged

[ModuleInterfaces] Escape Type and Protocol when module-qualifying #27065

merged 1 commit into from
Sep 11, 2019

Conversation

harlanhaskins
Copy link
Contributor

@harlanhaskins harlanhaskins commented Sep 6, 2019 •
edited by AnthonyLatsis
Loading

If we see MyModule.Type, the parser thinks this is a metatype type.
Escape the name Type and Protocol so the parser can recognize they're type names.

Fixes #53823
Fixes rdar://55094784

harlanhaskins
harlanhaskins commented Sep 6, 2019
View reviewed changes
@jrose-apple jrose-apple requested a review from beccadax September 6, 2019 21:56
@harlanhaskins
Copy link
Contributor Author

@swift-ci please smoke test

jrose-apple
jrose-apple reviewed Sep 6, 2019
View reviewed changes
beccadax
beccadax requested changes Sep 9, 2019
View reviewed changes
Copy link
Contributor

@beccadax beccadax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one small documentation change you definitely need to make; the rest I could be wrong about.

@harlanhaskins harlanhaskins force-pushed the type-and-circumstance branch 2 times, most recently from c59a128 to 8109832 Compare September 10, 2019 00:18
[ModuleInterfaces] Escape Type and Protocol when module-qualifying
2893d96 
If we see `MyModule.Type`, the parser thinks this is a metatype type.
Escape the name `Type` so the parser can recognize it's a type name.

Fixes [SR-11422](https://bugs.swift.org/browse/SR-11422) rdar://55094784
@harlanhaskins
Copy link
Contributor Author

@brentdax How's it look now?

@harlanhaskins
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - e7d8d249bf20e445eb982ef80cc4c3ffdf37beec

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - e7d8d249bf20e445eb982ef80cc4c3ffdf37beec

@harlanhaskins harlanhaskins merged commit 37382fe into swiftlang:master Sep 11, 2019
@harlanhaskins harlanhaskins mentioned this pull request Sep 6, 2019
Open
@AnthonyLatsis AnthonyLatsis linked an issue Oct 24, 2023 that may be closed by this pull request
[SR-11422] Generated .swiftinterface got an error when imported #53823
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beccadax beccadax beccadax approved these changes

+1 more reviewer

@jrose-apple jrose-apple jrose-apple left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SR-11422] Generated .swiftinterface got an error when imported
4 participants
@harlanhaskins @swift-ci @beccadax @jrose-apple