Skip to content

Compatibility50: Fix for high-bit characters. #27068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2019
Merged

Compatibility50: Fix for high-bit characters. #27068

merged 1 commit into from
Sep 11, 2019

Conversation

jckarter
Copy link
Contributor

@jckarter jckarter commented Sep 6, 2019

char might be signed. rdar://problem/55130240

@jckarter jckarter requested a review from mikeash September 6, 2019 22:26
mikeash
mikeash approved these changes Sep 7, 2019
View reviewed changes
Copy link
Contributor

@mikeash mikeash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱

@jckarter
Copy link
Contributor Author

jckarter commented Sep 7, 2019

@swift-ci please test

@jckarter jckarter merged commit 74d47f4 into swiftlang:master Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeash mikeash mikeash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jckarter @mikeash