[code-completion] Remove special handling for completion on the RHS of an assignment #27218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
nathawes
force-pushed
the
r53958454-getFixedTypeRecursive-code-completion-crash
branch
from
4e26659 to
a9c07cd
Compare
|
@swift-ci please test |
|
Build failed |
nathawes
changed the title
|
Build failed |
…f an assignment This simplifies the code and prevents an assertion failure this code was hitting computing the type relations between the result types and what it determined as the expected type. Resolves rdar://problem/53958454
nathawes
force-pushed
the
r53958454-getFixedTypeRecursive-code-completion-crash
branch
from
a9c07cd to
54defbc
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
🙇♂️ Thanks for suggesting it @rintaro! |
nathawes
deleted the
r53958454-getFixedTypeRecursive-code-completion-crash
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the code and prevents an assertion failure this code was hitting computing the type relations between the result types and what it determined as the expected type.
Resolves rdar://problem/53958454