-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[Doc] Fix errors in SIL.rst. #27476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] Fix errors in SIL.rst. #27476
Conversation
Feel free to merge without running CI. |
Installed Sphinx on all three CI machines to catch
|
I don't plan to land other patches soon so I'll start CI. |
@swift-ci Please test tensorflow |
Looks like another legitimate error, also in an .rst file:
|
macOS CI now fails with:
Investigating briefly, it seems others have ran into it here. If it's not easily fixable, I'll uninstall EDIT: I tried sphinx installed via |
@swift-ci Please test tensorflow macOS |
Fix "Title underline too short" errors. Sphinx has been installed on TensorFlow Ubuntu CI machines to catch doc errors. Sphinx is not installed on the macOS CI machine because doc building fails: `Pygments lexer name 'sil' is not known`.
This failure occurred only on the macOS CI machine: reproducing locally did not work. It may have been introduced in swiftlang#27471 but leaked through because the macOS CI machine was down at the time of testing.
macOS CI fails with a super weird error:
I ssh'd into the macOS CI machine and found that the
Note the newline after |
@swift-ci Please test tensorflow |
Fix "Title underline too short" errors:
Todo: install Sphinx on TensorFlow CI machines to catch these errors.