Correctly set the parent DeclContext of ParamDecls in EnumElementDecls #27583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an EnumElementDecl is parsed, we create the parameter list before creating the EnumElementDecl itself, so we have to re-parent those ParamDecls just like we do for functions and subscripts.
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
jrose-apple
reviewed
Oct 9, 2019
| // Read payload parameter list, if it exists. | ||
| if (hasPayload) { | ||
| auto *paramList = MF.readParameterList(); | ||
| elem->setParameterList(paramList); |
There was a problem hiding this comment.
Instead of delaying this, would it make more sense to serialize ParamDecls without a DeclContext?
There was a problem hiding this comment.
That sounds sensible. I'll take a crack at it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parent used to be the EnumDecl itself. When EnumElementDecls were refactored to themselves be DeclContexts we never updated this part. It's not really important right now, but my
validateDecl()request-ification changes require that the parent DeclContext of a ParamDecl is correctly set.