Skip to content

Conversation

rxwei
Copy link
Contributor

@rxwei rxwei commented Oct 14, 2019

This patch adds support for lowering @differentiable(linear) function types to LLVM IR.

  • Add SILFunctionType transpose type calculation utility: SILFunctionType:: getAutoDiffTransposeFunctionType.
  • Refactor TypeClassifierBase methods used for computing recursive properties of @differentiable function types and eliminated the need for repeatedly checking differentiability kind.
  • Add LinearDifferentiableSILFunctionTypeLowering. Rename the original DifferentiableSILFunctionTypeLowering to NormalDifferentiableSILFunctionTypeLowering to make clear it's not for linear functions.
  • Add TypeConverter::convertLinearDifferentiableFunctionType. Rename the original TypeConverter::convertDifferentiableFunctionType to TypeConverter::convertNormalDifferentiableFunctionType to make clear it's not for linear functions.

Resolves TF-902.

@rxwei rxwei added the tensorflow This is for "tensorflow" branch PRs. label Oct 14, 2019
@rxwei rxwei requested review from dan-zheng and marcrasi October 14, 2019 07:55
@rxwei rxwei force-pushed the irgen-differentiable-linear branch from ee0a324 to 39211c0 Compare October 14, 2019 07:56
@rxwei
Copy link
Contributor Author

rxwei commented Oct 14, 2019

@swift-ci please test tensorflow Linux

Co-Authored-By: Dan Zheng <danielzheng@google.com>
@rxwei
Copy link
Contributor Author

rxwei commented Oct 14, 2019

@swift-ci please test tensorflow

@rxwei
Copy link
Contributor Author

rxwei commented Oct 14, 2019

@swift-ci please test tensorflow

@rxwei
Copy link
Contributor Author

rxwei commented Oct 14, 2019

@swift-ci please test tensorflow

3 similar comments
@rxwei
Copy link
Contributor Author

rxwei commented Oct 14, 2019

@swift-ci please test tensorflow

@rxwei
Copy link
Contributor Author

rxwei commented Oct 14, 2019

@swift-ci please test tensorflow

@rxwei
Copy link
Contributor Author

rxwei commented Oct 14, 2019

@swift-ci please test tensorflow

@rxwei rxwei merged commit 4a4fe83 into swiftlang:tensorflow Oct 14, 2019
@rxwei rxwei deleted the irgen-differentiable-linear branch October 14, 2019 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tensorflow This is for "tensorflow" branch PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants