[Diagnostics] Port more key path related failures to new framework #27759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Key path components can reference an invalid or missing member just like regular expressions, so we need to account for that while trying to simplify key path constraint.
|
@swift-ci please smoke test |
hborla
approved these changes
Oct 17, 2019
xedin
commented
Oct 17, 2019
| @@ -229,7 +230,9 @@ func testDisembodiedStringInterpolation(x: Int) { | |||
|
|
|||
| func testNoComponents() { | |||
| let _: KeyPath<A, A> = \A // expected-error{{must have at least one component}} | |||
| // FIXME(diagnostics): This should be diagnosed as `missing generic parameter 'T'` instead of a contextual failure. | |||
| let _: KeyPath<C, A> = \C // expected-error{{must have at least one component}} expected-error{{}} | |||
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completely eliminates the need for
FailureDiagnosis::visitKeyPathExprby handling contextual mismatches as well as e.g. missing/invalid members via
new diagnostic framework.