[cmake] Do not override existing JOB_POOLS. #27888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building Swift as part of an LLVM distribution the global property JOB_POOLS would have been overriden by Swift. If one wanted parallel linking in LLVM, the job pools setup by LLVM would have disappered. This didn't happen in the standalone builds, because HandleLLVMOptions is included in that case _after_ the JOB_POOLS property would have been initialized without APPEND.
|
@swift-ci please smoke test |
compnerd
approved these changes
Oct 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building Swift as part of an LLVM distribution the global property
JOB_POOLS would have been overriden by Swift. If one wanted parallel
linking in LLVM, the job pools setup by LLVM would have disappered.
This didn't happen in the standalone builds, because HandleLLVMOptions
is included in that case after the JOB_POOLS property would have been
initialized without APPEND.
Related to compnerd/swift-build#53