DestroyHoisting: support of begin_apply and end_apply instructions

[eeckstein]

This enables destroy hoisting when accessor co-routines are not yet inlined.

https://bugs.swift.org/browse/SR-11675
rdar://problem/56704059

[eeckstein]

@swift-ci test

[eeckstein]

@swift-ci benchmark

[swift-ci]

Performance: -O

Code size: -O

Regression	OLD	NEW	DELTA	RATIO
ArraySubscript.o	3586	3634	+1.3%	0.99x

Performance: -Osize

Improvement	OLD	NEW	DELTA	RATIO
SuffixCountableRangeLazy	12	11	-8.3%	1.09x (?)

Code size: -Osize

Regression	OLD	NEW	DELTA	RATIO
ArraySubscript.o	3690	3738	+1.3%	0.99x

Performance: -Onone

Code size: -swiftlibs

How to read the data

The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview

  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

[swift-ci]

Build failed
Swift Test Linux Platform
Git Sha - fbd41f7

[swift-ci]

Build failed
Swift Test OS X Platform
Git Sha - fbd41f7

[eeckstein]

@swift-ci test

[weissi]

@eeckstein Awesome, thank you! This is affecting the performance of an upcoming SwiftNIO feature. Do you think this would be safe enough to backport to swift-5.1-branch? The patch looks quite innocent to me :)

[eeckstein]

@weissi Unfortunately not. The whole destroy hoisting optimization is not on the 5.1 branch yet.

[weissi]

@eeckstein got it, thank you!