Skip to content

Debug Info: Avoid type uniquing clashes for bound generic structs #28029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2019
Merged

Debug Info: Avoid type uniquing clashes for bound generic structs #28029

merged 1 commit into from
Nov 5, 2019

Conversation

adrian-prantl
Copy link
Contributor

This is #28020 for structs.

@adrian-prantl
Copy link
Contributor Author

test with #28020
@swift-ci test

@swift-ci
Copy link
Contributor

swift-ci commented Nov 2, 2019

Build failed
Swift Test OS X Platform
Git Sha - 893756176b6816ad3e88468cef7641e758b000e1

@swift-ci
Copy link
Contributor

swift-ci commented Nov 2, 2019

Build failed
Swift Test Linux Platform
Git Sha - 893756176b6816ad3e88468cef7641e758b000e1

@adrian-prantl
Copy link
Contributor Author

test with #28020
@swift-ci test

1 similar comment
@adrian-prantl
Copy link
Contributor Author

test with #28020
@swift-ci test

@swift-ci
Copy link
Contributor

swift-ci commented Nov 4, 2019

Build failed
Swift Test Linux Platform
Git Sha - 59cac2e38445962980ae488494a4f302e5870e09

@swift-ci
Copy link
Contributor

swift-ci commented Nov 4, 2019

Build failed
Swift Test OS X Platform
Git Sha - 59cac2e38445962980ae488494a4f302e5870e09

@adrian-prantl
Copy link
Contributor Author

test with #28020
@swift-ci test

@swift-ci
Copy link
Contributor

swift-ci commented Nov 4, 2019

Build failed
Swift Test Linux Platform
Git Sha - 59cac2e38445962980ae488494a4f302e5870e09

@swift-ci
Copy link
Contributor

swift-ci commented Nov 4, 2019

Build failed
Swift Test OS X Platform
Git Sha - 59cac2e38445962980ae488494a4f302e5870e09

@adrian-prantl
Debug Info: Avoid type uniquing clashes for bound generic structs.
8e9b028 
This patch changes the DWARF representation of bound generic struct to a nested
struct where the (sized) outer struct is anonymous and thus distinct and the
inner struct in uniqued and sizeless.

This is anologous the the previous commit that did the same thing for bound
generic enums.

rdar://problem/56521648
@adrian-prantl
Copy link
Contributor Author

@swift-ci test

@swift-ci
Copy link
Contributor

swift-ci commented Nov 4, 2019

Build failed
Swift Test OS X Platform
Git Sha - 59cac2e38445962980ae488494a4f302e5870e09

@swift-ci
Copy link
Contributor

swift-ci commented Nov 4, 2019

Build failed
Swift Test Linux Platform
Git Sha - 59cac2e38445962980ae488494a4f302e5870e09

@adrian-prantl adrian-prantl merged commit 49c0ae4 into swiftlang:master Nov 5, 2019
@vedantk
Copy link
Contributor

vedantk commented Nov 5, 2019

LGTM, but does this need an additional test in lldb, or is it already covered?

@adrian-prantl
Copy link
Contributor Author

This is handled by the same generic code as the bounded enum case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vedantk vedantk Awaiting requested review from vedantk

@slavapestov slavapestov Awaiting requested review from slavapestov

@dcci dcci Awaiting requested review from dcci

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adrian-prantl @swift-ci @vedantk