Skip to content

[Diagnostics][CSDiag] Removing invalid_force_unwrap diagnostic from CSDiag #28047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2019
Merged

[Diagnostics][CSDiag] Removing invalid_force_unwrap diagnostic from CSDiag #28047

merged 1 commit into from
Nov 4, 2019

Conversation

LucianoPAlmeida
Copy link
Contributor

Notice that this is already being diagnosed via fix (RemoveUnwrap)
So we can remove this code from CSDiag :)

cc @xedin @hborla

xedin
xedin approved these changes Nov 4, 2019
View reviewed changes
Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@xedin
Copy link
Contributor

xedin commented Nov 4, 2019

@swift-ci please smoke test and merge

@swift-ci swift-ci merged commit aefaa14 into swiftlang:master Nov 4, 2019
@LucianoPAlmeida LucianoPAlmeida deleted the removing-non-opnional-csdiag-code branch November 4, 2019 03:57
@LucianoPAlmeida LucianoPAlmeida mentioned this pull request Nov 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xedin xedin xedin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LucianoPAlmeida @xedin @swift-ci