Skip to content

Conversation

hamishknight
Copy link
Contributor

This PR removes uses of TypeChecker from MiscDiagnostics as well as a bunch of cases from the constraint system, cherry-picked from 413cb3f. It also removes an unnecessary call to createTypeChecker from performTypeLocChecking.

@hamishknight hamishknight requested a review from CodaFi November 7, 2019 20:45
@hamishknight
Copy link
Contributor Author

@swift-ci please test

@hamishknight
Copy link
Contributor Author

@swift-ci please test OS X platform

@swiftlang swiftlang deleted a comment from swift-ci Nov 7, 2019
@theblixguy
Copy link
Collaborator

macOS failure is unrelated and should be fixed by #28136

@hamishknight
Copy link
Contributor Author

@swift-ci please test OS X platform

@swiftlang swiftlang deleted a comment from swift-ci Nov 7, 2019
Copy link
Contributor

@CodaFi CodaFi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@hamishknight hamishknight merged commit f519505 into swiftlang:master Nov 8, 2019
@hamishknight hamishknight deleted the bouncing-your-check branch November 8, 2019 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants