AST: Fix combineSubstitutionMaps() for requirements placed on outer generic parameters #28147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
force-pushed
the
devirt-outer-param-requirement
branch
from
edfe78f to
5ddaa58
Compare
|
@swift-ci Please smoke test |
…eneric parameters There's an evolution proposal going through that allows for this in more places, so let's fix a known bug in this area. Fixes <https://bugs.swift.org/browse/SR-10073>, <rdar://problem/48925725>.
slavapestov
force-pushed
the
devirt-outer-param-requirement
branch
from
5ddaa58 to
88cbcea
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugs.swift.org/browse/SR-10073, rdar://problem/48925725.
Also adds two small unrelated changes since I'm lazy about PR testing: