[pmo] Add a few more asserts before I fix strong control equivalence issues #28196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lues when promoting takes. The key thing to note here is that when we are processing a take, we validate that at all destroy points we have a fully available value. So we should never hit this code path which is correct. This assert just makes the assumption clearer in the small when reading code locally in handlePrimitiveValue.
…ve singular values if the underlying type is either trivial or we have a take. The reason why this is true is that we will be inserting new copy_values for each available value implying that we can never have such a singular value. I also added two test cases that show that we have a singular value with the trivial type and that works.
|
@swift-ci smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two more asserts that I am using to validate some assumptions in the pass before I fix it for the strong control equivalence issues in between copies.