Skip to content

Ensure that we have a valid witness to IteratorProtocol.next() #28358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2019
Merged

Ensure that we have a valid witness to IteratorProtocol.next() #28358

merged 1 commit into from
Nov 21, 2019

Conversation

CodaFi
Copy link
Contributor

@CodaFi CodaFi commented Nov 19, 2019

Resolves rdar://57003406

@CodaFi
Copy link
Contributor Author

CodaFi commented Nov 19, 2019

@swift-ci please smoke test and merge

@CodaFi
Copy link
Contributor Author

CodaFi commented Nov 19, 2019

Hm, seems like an infrastructure problem

@swift-ci please smoke test

slavapestov
slavapestov requested changes Nov 20, 2019
View reviewed changes
Copy link
Contributor

@slavapestov slavapestov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a test case.

@CodaFi
Copy link
Contributor Author

CodaFi commented Nov 21, 2019

Reducing Alex's test is proving difficult. I'll get it in a follow-on.

@swift-ci please smoke test

@CodaFi
Copy link
Contributor Author

CodaFi commented Nov 21, 2019

⛵️

@CodaFi CodaFi merged commit 7ff18df into swiftlang:master Nov 21, 2019
@CodaFi CodaFi deleted the witness-protection-program branch November 21, 2019 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slavapestov slavapestov slavapestov requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CodaFi @slavapestov