Skip to content

Pull SE-0081 into Swift 3.0 Preview 1 #2850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 2, 2016
Merged

Pull SE-0081 into Swift 3.0 Preview 1 #2850

merged 2 commits into from
Jun 2, 2016

Conversation

tkremenek
Copy link
Member

@tkremenek tkremenek commented Jun 2, 2016 •
edited
Loading

Pull SE-0081 into Swift 3.0 Preview 1.

lattner added 2 commits June 2, 2016 12:10
@lattner @tkremenek
Implement parser support for SE-0081 - Move 'where' clause to end of …
c6ca051 
…declaration

This patch includes testsuite changes to show each of the decls supported.

Next step is to migrate the stdlib + testsuite + corelibs: I'd would *greatly* appreciate help with this.

After that is done, deprecation + migration of the old form can happen.
@lattner @tkremenek
My recent patch "broke" these tests, but allowing the syntax in them …
360f7ee 
…to trigger existing generics bugs.
@tkremenek tkremenek added this to the Swift 3.0 Preview 1 milestone Jun 2, 2016
@tkremenek
Copy link
Member Author

@swift-ci smoke test OS X platform

@tkremenek
Copy link
Member Author

@swift-ci test linux

jckarter
jckarter reviewed Jun 2, 2016
View reviewed changes
CHANGELOG.md

```swift
func anyCommonElements<T : SequenceType, U : SequenceType>(lhs: T, _ rhs: U) -> Bool
where T.Generator.Element: Equatable, T.Generator.Element == U.Generator.Element>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing > at the end of the line there.

@tkremenek
Copy link
Member Author

@DougGregor can you review this?

@tkremenek
Copy link
Member Author

@rjmccall can you review?

@rjmccall
Copy link
Contributor

rjmccall commented Jun 2, 2016

LGTM.

@tkremenek tkremenek merged commit 30a30e1 into swiftlang:swift-3.0-preview-1-branch Jun 2, 2016
@DougGregor
Copy link
Member

Note that this crashes if you add a where clause to something that isn't generic:

protocol P { }

struct X<T> {
  func f() where T : P { }
}

@rjmccall
Copy link
Contributor

rjmccall commented Jun 2, 2016

Yeah, I realized after LGTM'ing that this case was problematic; sorry, Ted. Doug and I talked about it, and the patch needs to be fixed to not make promises we're not ready for.

@tkremenek tkremenek mentioned this pull request Jun 3, 2016
Merged
@tkremenek
Copy link
Member Author

Reverted in #2860

@tkremenek
Copy link
Member Author

@rjmccall @DougGregor do we have a bug report for this case?

@gribozavr
Copy link
Contributor

gribozavr commented Jun 3, 2016 •
edited
Loading

@tkremenek We also need syntax highlighting, code completion, formatting, and interface printing support. It might just fall out from existing infrastructure, but it can also crash badly -- we don't know yet. We need to add tests for these IDE features even if they happen to work perfectly fine with the new syntax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Swift 3.0 Preview 1
Development

Successfully merging this pull request may close these issues.
6 participants
@tkremenek @rjmccall @DougGregor @gribozavr @jckarter @lattner