[AutoDiff] forbid overly-constrained derivative requirement implementations #28716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcrasi
force-pushed
the
marcrasi-unsatisfied-generic-requirement
branch
from
67c94b6 to
3480227
Compare
rxwei
approved these changes
Dec 11, 2019
|
@swift-ci please test tensorflow |
|
This seemed a bit risky, so I ran swift-apis tests on them. They passed. |
|
@swift-ci please test tensorflow macos |
marcrasi
pushed a commit
that referenced
this pull request
Dec 12, 2019
This PR puts the generic signature of the original function in the `DifferentiableAttribute`, solving TF-1046. This exposed 3 latent bugs, which I had to deal with: * `getNextOverriddenVTableEntry` was returning a result with the generic signature of the overriding derivative, but it should return a result with the generic signature of the overridden derivative. * TF-1055. Dealt with by adding a special case. See `TODO(TF-1055)` in the code. * #28716 is incorrect for conditional conformances because the conformance condition (which is part of the witness generic signature) is not satisfied by the requirement. This PR exposed the incorrectness and caused some tests to fail. I fixed it by expanding the check from #28716 to accept witness requirements that are satisfied by the conformance condition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As demonstrated in the new test file, we should reject derivative requirement implementations that are too constrained.