Skip to content

Conversation

YOCKOW
Copy link
Member

@YOCKOW YOCKOW commented Dec 16, 2019

Since 1b4b7f9 has been committed, update-checkout clones "llvm-project" repo but does not clone "llvm" repo itself alone by default.
That may cause run-test failure because "lit.py" cannot be found.
This PR resolves the issue.

@CodaFi
Copy link
Contributor

CodaFi commented Dec 16, 2019

@swift-ci please python lint

@CodaFi
Copy link
Contributor

CodaFi commented Dec 16, 2019

Thanks!

@swift-ci please test and merge.

@YOCKOW
Copy link
Member Author

YOCKOW commented Dec 17, 2019

It seems to have failed due to the lack of my understanding of python lint...
I'll fix it.

Since swiftlang@1b4b7f9 has been committed, `update-checkout` clones "llvm-project" repo but does not clone "llvm" repo itself alone by default.
That may cause `run-test` failure because "lit.py" cannot be found.
This commit fixes the issue.
@YOCKOW YOCKOW force-pushed the run-test-llvm-project-path branch from eebe628 to 90a33fa Compare December 17, 2019 05:41
@YOCKOW
Copy link
Member Author

YOCKOW commented Dec 17, 2019

Fixed python code to pass the lint.

@CodaFi
Copy link
Contributor

CodaFi commented Dec 17, 2019

@swift-ci please python lint

@CodaFi
Copy link
Contributor

CodaFi commented Dec 17, 2019

@swift-ci please test

1 similar comment
@CodaFi
Copy link
Contributor

CodaFi commented Dec 17, 2019

@swift-ci please test

@YOCKOW
Copy link
Member Author

YOCKOW commented Dec 19, 2019

@CodaFi
Thank you for rerunning tests to be passed.

@CodaFi
Copy link
Contributor

CodaFi commented Dec 19, 2019

⛵️

@CodaFi CodaFi merged commit 15bcf53 into swiftlang:master Dec 19, 2019
@YOCKOW YOCKOW deleted the run-test-llvm-project-path branch December 19, 2019 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants