[LookupVisibleDecls] Look through DynamicSelfType in meta type lookup #29346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
This is fine, but please add a test case. I'm hoping that one day we can scrap LookupVisibleDecls and merge it with the normal qualified lookup path, so at this point, the test cases have more long term value than the code itself :-) |
|
Ah, I forgot to |
slavapestov
approved these changes
Jan 22, 2020
We need to unwrap DynamicSelfType to get the visible decls on the meta type. rdar://problem/58778439
rintaro
force-pushed
the
ide-completion-rdar58778439
branch
from
9242273 to
43ad81c
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to unwrap DynamicSelfType to get the visible decls on the meta type.
rdar://problem/58778439