-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[Incremental] Supports per-type-body fingerprints, on-by-default #29463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci please smoke test os x platform |
00742cf
to
d78eb47
Compare
@swift-ci please smoke test os x platform |
@swift-ci please clean smoke test os x platform |
d78eb47
to
f1c17f4
Compare
@swift-ci please smoke test os x platform |
f1c17f4
to
62937e2
Compare
@swift-ci please smoke test |
271eccd
to
4510c2f
Compare
@swift-ci please smoke test |
Why MD5? Why not SHA1 or SHA256 which can be hardware accelerated on some processors? (Yes, SHA1 is slightly bigger, but you can just truncate the result if that matters.) |
I imagine it’s because LLVM already has the facilities for this. I’d prefer we use something like 128-bit siphash but it’s certainly a decision we can revisit. |
Yes, the use of MD5 follows what was done for the original, whole-file, interface hash. |
[DNM, Incremental: Type-body-fingerprints on-by-default]
-- A virtually-identical PR, 29482, has been examined by @CodaFi