Skip to content

[Draft] Demonstrate dropping count field from FixedArray #29516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[Draft] Demonstrate dropping count field from FixedArray #29516

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions stdlib/public/core/FixedArray.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ internal struct _FixedArray16<T> {
T, T, T, T, T, T, T, T
)

var _count: Int8
// var _count: Int8
}

extension _FixedArray16 {
Expand All @@ -37,8 +37,8 @@ extension _FixedArray16 {
}

internal var count: Int {
@inline(__always) get { return Int(truncatingIfNeeded: _count) }
@inline(__always) set { _count = Int8(newValue) }
@inline(__always) get { return 16 } // Int(truncatingIfNeeded: _count) }
// @inline(__always) set { _count = Int8(newValue) }
}
}

Expand Down Expand Up @@ -90,11 +90,11 @@ extension _FixedArray16: RandomAccessCollection, MutableCollection {
}

extension _FixedArray16 {
internal mutating func append(_ newElement: T) {
_internalInvariant(count < capacity)
_count += 1
self[count-1] = newElement
}
// internal mutating func append(_ newElement: T) {
// _internalInvariant(count < capacity)
// _count += 1
// self[count-1] = newElement
// }
}

extension _FixedArray16 where T: ExpressibleByIntegerLiteral {
Expand All @@ -105,7 +105,7 @@ extension _FixedArray16 where T: ExpressibleByIntegerLiteral {
0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0
)
self._count = Int8(truncatingIfNeeded: count)
// self._count = Int8(truncatingIfNeeded: count)
}

@inline(__always)
Expand Down