Skip to content

Conversation

vedantk
Copy link
Contributor

@vedantk vedantk commented Feb 6, 2020

Add an on-by-default option to build swift's benchmarks with debug info.

This lets us use the benchmark driver to find lldb bugs, e.g. rdar://59209520.

@vedantk vedantk requested a review from gottesmm February 6, 2020 01:47
@gottesmm
Copy link
Contributor

gottesmm commented Feb 6, 2020

LGTM

@vedantk
Copy link
Contributor Author

vedantk commented Feb 6, 2020

@swift-ci smoke test and merge

@vedantk
Copy link
Contributor Author

vedantk commented Feb 6, 2020

Linux failure: make[1]: *** [out/build/icudt65l/zoneinfo64.res] Bus error (core dumped)

@vedantk
Copy link
Contributor Author

vedantk commented Feb 6, 2020

@swift-ci smoke test linux platform

@vedantk vedantk merged commit 609c84b into swiftlang:master Feb 6, 2020
@vedantk vedantk deleted the debug-bench branch February 6, 2020 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants