[CodeCompletion] Enable fast-completion at the top of implicit getter #29789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a CC token is right after the '{' we still don't know it's an implicit
getter or a start of a accessor block. Previously, the parser used to
parse it as an accessor block, but it prevents fast-completion kicks in.
Instead handle it as a part of function body parsing so the
fast-completion works.
rdar://problem/58851121
|
@swift-ci Please smoke test |
rintaro
changed the title
rintaro
changed the title
benlangmuir
reviewed
Feb 13, 2020
| addParametersToScope(AFD->getParameters()); | ||
|
|
||
| // Establish the new context. | ||
| ParseFunctionBody CC(*this, AFD); |
There was a problem hiding this comment.
This changes the lifetime of the body context. Is that correct? Is there any risk this will cause issues if someone modifies this in the future? The body is not "finished" here, since we have the transform below.
There was a problem hiding this comment.
The transformation below doesn't use CurDeclContext nor CurLocalContext. So this lifetime change should not affect it. Am I missing something?
Is there any risk this will cause issues if someone modifies this in the future?
In general, a parser developer should know what the current CurDeclContext. What is your concern exactly?
benlangmuir
approved these changes
Feb 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a CC token is right after the '{' we still don't know it's an implicit getter or a start of a accessor block. Previously, the parser used to parse it as an accessor block, but it prevents fast-completion kicks in.
Instead handle it as a part of function body parsing so the fast-completion works.
rdar://problem/58851121
Groundwork:
AbstructFunctionDeclbody parsing functionsAccessorDecl::isImplictGetter()function