[5.2][CodeCompletion] Fix a crash in context type analysis #29829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'IfExpr' (ternary expression) does not have condition part before sequence folding. Add a guard to avoid a crash. rdar://problem/59344203 (cherry picked from commit 9cb2c05)
|
@swift-ci Please test |
|
@swift-ci Please nominate |
akyrtzi
approved these changes
Feb 14, 2020
rintaro
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #29816 into
swift-5.2-branchExplanation: Fix a crash in context type analysis for
IfExpr(ternary expression) in code completions. Before sequence folding,IfExprdoesn't have the condition part. When they somehow aren't type checked prior to the code completion analysis, it used to crash because of the lack of thenullptrcheck.Scope: Code completion inside "then" part of ternary expressions.
Risk: Very low. Just add a check to guard.
Issue: rdar://problem/59344203
Testing: Passed the current regression test. (No additional test because I haven't been able to find a reproducer)
Reviewer: Nathan Hawes (@nathawes)