Skip to content

[Parse] Improve recovery from and diagnostics for invalid operator names #29955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 25, 2020
Merged

[Parse] Improve recovery from and diagnostics for invalid operator names #29955

merged 2 commits into from
Feb 25, 2020

Conversation

AnthonyLatsis
Copy link
Collaborator

@AnthonyLatsis AnthonyLatsis commented Feb 20, 2020 •
edited
Loading

More accurate diagnostics for invalid or ambiguous characters in operator names that also improve recovery as a consequence.

Here are some affected examples:

infix operator =
infix operator ->
infix operator ?
postfix operator !==
infix operator -oo-
infix operator =#=
infix operator ?#$

@AnthonyLatsis
Copy link
Collaborator Author

AnthonyLatsis commented Feb 20, 2020 •
edited
Loading

cc @rintaro @nkcsgexi

@theblixguy theblixguy requested a review from rintaro February 20, 2020 17:17
rintaro
rintaro requested changes Feb 21, 2020
View reviewed changes
Copy link
Member

@rintaro rintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements!

@rintaro
Copy link
Member

rintaro commented Feb 25, 2020

@swift-ci Please smoke test

@AnthonyLatsis
Copy link
Collaborator Author

Thanks for the help in improving the changes!

rintaro
rintaro approved these changes Feb 25, 2020
View reviewed changes
Copy link
Member

@rintaro rintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you Anthony!

@rintaro rintaro merged commit 571d09a into swiftlang:master Feb 25, 2020
@AnthonyLatsis AnthonyLatsis deleted the operator-diag-qoi branch February 17, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rintaro rintaro rintaro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnthonyLatsis @rintaro