Skip to content

[swift-3.0-preview-2-branch][stdlib] unavailable String APIs: use Swift 2.x APIs without first argument labels #3022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gribozavr
Copy link
Contributor

@gribozavr gribozavr commented Jun 15, 2016

Explanation: correct the signatures of the unavailable advancedBy and distanceTo methods on String indices.

Scope of the issue: migration of code that uses string indices.

Risk: low.

Reviewed by: @moiseev.

Testing: manual.


Before merging this pull request to apple/swift repository:

  • Test pull request on Swift continuous integration.

Triggering Swift CI

The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:

Smoke Testing

Platform Comment
All supported platforms @swift-ci Please smoke test
All supported platforms @swift-ci Please smoke test and merge
OS X platform @swift-ci Please smoke test OS X platform
Linux platform @swift-ci Please smoke test Linux platform

Validation Testing

Platform Comment
All supported platforms @swift-ci Please test
All supported platforms @swift-ci Please test and merge
OS X platform @swift-ci Please test OS X platform
OS X platform @swift-ci Please benchmark
Linux platform @swift-ci Please test Linux platform

Lint Testing

Language Comment
Python @swift-ci Please Python lint

Note: Only members of the Apple organization can trigger swift-ci.

@gribozavr
Copy link
Contributor Author

@swift-ci Please test

@gribozavr gribozavr added this to the Swift 3.0 Preview 2 milestone Jun 15, 2016
@shahmishal
Copy link
Member

@swift-ci Please test

1 similar comment
@shahmishal
Copy link
Member

@swift-ci Please test

@moiseev
Copy link
Contributor

moiseev commented Jun 15, 2016

:shipit:

@gribozavr gribozavr force-pushed the stdlib-unavailable-string-apis branch from 0f71435 to 3fdec61 Compare June 16, 2016 13:48
@gribozavr
Copy link
Contributor Author

@swift-ci Please test

@tkremenek
Copy link
Member

@swift-ci test

@tkremenek tkremenek merged commit e0a3204 into swift-3.0-preview-2-branch Jun 21, 2016
@gribozavr gribozavr deleted the stdlib-unavailable-string-apis branch June 21, 2016 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants