[stdlib] Addressing Dmitri Gribenko's feedback re #2993 #3047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinzheng
force-pushed
the
az-fix-tests
branch
2 times, most recently
from
85aee52 to
e9e6da9
Compare
|
@swift-ci Please test and merge |
Changes: - Moved only-used-once helper methods into call sites - Parameterized tests that might expect a crash - Fixed some comments and formatting; renamed some test helper APIs
austinzheng
force-pushed
the
az-fix-tests
branch
from
e9e6da9 to
9138b73
Compare
|
@gribozavr Sorry, you'll have to trigger the CI again :(. I pushed a fix to a unit test right after you started it. |
|
You were absolutely right, by the way; at least one error in the test definitions was uncovered by parameterizing the tests. |
|
@swift-ci Please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Improvements per comments on #2993 @gribozavr @moiseev
(Will update this space once OS X tests pass or fail)
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.
Changes: