Skip to content

[Autodiff upstream] Upstream autodiff unittests #30709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 30, 2020

Conversation

ematejska
Copy link
Contributor

Upstream autodiff unittests.

This resolves TF-1129.

@ematejska ematejska requested review from dan-zheng and marcrasi March 29, 2020 04:28
@ematejska
Copy link
Contributor Author

@swift-ci please smoke test

C.TheEmptyTupleType)),
IndexSubset::get(C, 6, {0, 1, 2, 5}));
// Method (T) -> ((T, T), (T, T), T) -> ()
// TODO(TF-874): Fix this unit test.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I have WIP for fixing TF-874 and uncommenting this unit test. It's a bit invasive, so it probably makes sense to land after AutoDiff upstreaming is done.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@ematejska ematejska merged commit 1420b81 into swiftlang:master Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants