Skip to content

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Jun 20, 2016

What's in this pull request?

${Distance} should be ${View}.IndexDistance, not ${View}.Index.

Added test cases for expected-errors and validating that the suggested fix would work.
Maybe, exact expected-error is not necessary and is fragile.
But I'm not sure which is the necessary and sufficient part :(


Before merging this pull request to apple/swift repository:

  • Test pull request on Swift continuous integration.

Added test cases for expected-errors and validating that suggested fix works.
@rintaro
Copy link
Member Author

rintaro commented Jun 20, 2016

@swift-ci Please test

@gribozavr gribozavr merged commit f80d68d into swiftlang:master Jun 21, 2016
@rintaro rintaro deleted the unavailablestringapi-distance branch June 21, 2016 09:24
kateinoigakukun pushed a commit to kateinoigakukun/swift that referenced this pull request Sep 5, 2021
Resolve conflicts with the main branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants