Skip to content

[stdlib] Removes redundant buffer zeroing in foreignErrorCorrectedGrapheme func by using `init(unsafeUninitializedCapacity:initializingWith:) #31105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 24, 2020
Merged

[stdlib] Removes redundant buffer zeroing in foreignErrorCorrectedGrapheme func by using `init(unsafeUninitializedCapacity:initializingWith:) #31105

merged 1 commit into from
Aug 24, 2020

Conversation

valeriyvan
Copy link
Contributor

Removes redundant buffer zeroing in foreignErrorCorrectedGrapheme func by using `init(unsafeUninitializedCapacity:initializingWith:)

@theblixguy theblixguy requested a review from milseman April 17, 2020 21:01
@valeriyvan
Copy link
Contributor Author

ping

1 similar comment
@valeriyvan
Copy link
Contributor Author

ping

@valeriyvan valeriyvan changed the title Removes redundant buffer zeroing in foreignErrorCorrectedGrapheme func by using `init(unsafeUninitializedCapacity:initializingWith:) [stdlib] Removes redundant buffer zeroing in foreignErrorCorrectedGrapheme func by using `init(unsafeUninitializedCapacity:initializingWith:) Jun 14, 2020
@valeriyvan
Copy link
Contributor Author

ping

2 similar comments
@valeriyvan
Copy link
Contributor Author

ping

@valeriyvan
Copy link
Contributor Author

ping

milseman
milseman approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@milseman milseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@milseman
Copy link
Member

@swift-ci please test and merge

@valeriyvan
Copy link
Contributor Author

ping

1 similar comment
@valeriyvan
Copy link
Contributor Author

ping

@kylemacomber kylemacomber merged commit d71d92e into swiftlang:master Aug 24, 2020
@valeriyvan valeriyvan deleted the RemoveRedundantBufferZeroingUnicodeHelpers branch August 25, 2020 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milseman milseman milseman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@valeriyvan @milseman @kylemacomber