Skip to content

Excise the Global LLVM Context #31113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2020

Conversation

CodaFi
Copy link
Contributor

@CodaFi CodaFi commented Apr 17, 2020

Add a private scratch context to the ASTContext and allow IntrinsicInfo sole access to it so it can allocate attributes into it. This removes the final dependency on the global context.

Thus ends my reign of terror.

@CodaFi
Copy link
Contributor Author

CodaFi commented Apr 17, 2020

@swift-ci test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 9f3c3b8872b73039d0ab36b621a7fa73649affda

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 9f3c3b8872b73039d0ab36b621a7fa73649affda

Add a private scratch context to the ASTContext and allow IntrinsicInfo sole access to it so it can allocate attributes into it. This removes the final dependency on the global context.
@CodaFi CodaFi force-pushed the a-little-less-context-would-be-nice branch from 9f3c3b8 to e2cab42 Compare April 18, 2020 00:48
@CodaFi
Copy link
Contributor Author

CodaFi commented Apr 18, 2020

@swift-ci test

1 similar comment
@CodaFi
Copy link
Contributor Author

CodaFi commented Apr 18, 2020

@swift-ci test

Copy link
Contributor

@davidungar davidungar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CodaFi
Copy link
Contributor Author

CodaFi commented Apr 18, 2020

@swift-ci test Windows

@CodaFi
Copy link
Contributor Author

CodaFi commented Apr 18, 2020

@CodaFi CodaFi merged commit e884b70 into swiftlang:master Apr 18, 2020
@CodaFi CodaFi deleted the a-little-less-context-would-be-nice branch April 18, 2020 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants