[Fixit] Provide fixit when converting expressions of type T to [T] or… #3112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… UnsafePointer<T>.
|
@swift-ci Please test and merge |
|
Isn't inserting just '&' simpler? |
|
I think in that case we need separate paths for UnsafePointer and Array. Any advantage of using &? |
It does not allocate an array on the heap. |
|
@swift-ci Please test and merge |
|
@gribozavr Sounds reasonable. I have changed [] to & for the UnsafePointer case. |
| return true; | ||
| } | ||
| } | ||
| } else if (contextDecl == CS->TC.Context.getUnsafePointerDecl()) { |
There was a problem hiding this comment.
What about UnsafeMutablePointer?
There was a problem hiding this comment.
Can we fix that in the same way?
|
@swift-ci Please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This another fixit I found useful when helping developers migrate. When an expected argument is of type [T] or UnsafePointer, however the developer feeds an expression of Type T, the fixit adds brackets to the expression.
Resolved bug number: (SR-)
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.
… UnsafePointer.