Skip to content

Add syntax highlighting for GitHub #31219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2020
Merged

Add syntax highlighting for GitHub #31219

merged 1 commit into from
Apr 23, 2020

Conversation

ZevEisenberg
Copy link
Contributor

@ZevEisenberg ZevEisenberg commented Apr 22, 2020

I came across these docs while researching when a closure's return type can be inferred, and wanted to leave them better than I found them.

@xwu xwu requested a review from owenv April 22, 2020 22:23
@CodaFi
Copy link
Contributor

CodaFi commented Apr 22, 2020

I presume Github-flavored markdown is our dialect of choice considering the original markdown spec makes no affordances for code fencing.

@swift-ci smoke test

Copy link
Contributor

@owenv owenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

We're using the same markdown dialect as in doc comments (commonmark w/ custom extensions). This meets the spec and I ran a quick test and verified it renders correctly in the terminal.

@CodaFi
Copy link
Contributor

CodaFi commented Apr 23, 2020

@CodaFi CodaFi merged commit 03f4b34 into swiftlang:master Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants