TempRValueOpt: fix a compile time crash in tryOptimizeStoreIntoTemp #31232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bail if there is any kind of user which is not handled in this transformation.
|
@swift-ci smoke test |
|
@swift-ci smoke test linux |
1 similar comment
|
@swift-ci smoke test linux |
gottesmm
reviewed
Apr 23, 2020
| case SILInstructionKind::MarkDependenceInst: | ||
| continue; | ||
| default: | ||
| return {std::next(si->getIterator()), false}; |
There was a problem hiding this comment.
I want to think about this a little more, but can you change this to crash in asserts builds? I think that might be a nice way to square the circle of not crashing in non-asserts builds but also getting noise when we do not update all of the relevant code. Creating implicit dependencies in the code like this, makes me nervous.
There was a problem hiding this comment.
No, that doesn't make sense.
Why should there be an assert for a case which totally legal to happen and we know how to reproduce it?
There was a problem hiding this comment.
Ah ok. I understand what you are doing now. LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bail if there is any kind of user which is not handled in this transformation.