Skip to content

[CxxInterop] Add tests for static variables #31362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2020

Conversation

hlopko
Copy link
Contributor

@hlopko hlopko commented Apr 28, 2020

@gribozavr gribozavr added the c++ interop Feature: Interoperability with C++ label Apr 28, 2020
@gribozavr
Copy link
Contributor

@swift-ci Please test

@gribozavr
Copy link
Contributor

@swift-ci Please test Windows

@gribozavr gribozavr merged commit 4263e7b into swiftlang:master Apr 29, 2020
@atrick
Copy link
Contributor

atrick commented Apr 30, 2020

@hlopko I'm not sure how this failure got through PR testing. Have you already fixed it or do I need to XFAIL the test?

https://ci.swift.org/job/oss-swift_tools-RA_stdlib-DA_test-device-non_executable/70/consoleFull

TEST 'Swift(iphoneos-armv7) :: Interop/Cxx/static/static-var-irgen.swift' FAILED

test/Interop/Cxx/static/static-var-irgen.swift:49:11: error: CHECK: expected string not found in input
// CHECK: call {{void @_ZN10NonTrivialC[12]Ei(%class.NonTrivial* @_ZL16staticNonTrivial, i32 1024)|%class.NonTrivial* @"??0NonTrivial@@qeaa@H@Z"(%class.NonTrivial* @staticNonTrivial, i32 1024)}}
^
:67:49: note: scanning from here
define internal void @__cxx_global_var_init.4() #0 section "__TEXT,__StaticInit,regular,pure_instructions" {
^

@hlopko
Copy link
Contributor Author

hlopko commented May 4, 2020

Fix coming in #31530. Thanks for reporting.

As for why it was not caught by presubmits, I though we only have macos presubmits, no ios? Maybe @shahmishal can clarify?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants