Register operator dependencies on direct lookup requests #31456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure a dependency gets registered when a direct lookup is fired off. This is necessary in order to ensure that operator redeclaration checking records the right dependencies (and any future logic that might want to perform direct operator lookups). In doing so, this commit also removes the compatibility logic for the old referenced name tracker that would skip recording dependencies in certain cases. This should be safe as the new logic will record strictly more dependencies than the old logic.
|
@swift-ci please test |
CodaFi
approved these changes
Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure a dependency gets registered when a direct lookup for an operator or precedence group decl is fired off. This is necessary in order to ensure that operator redeclaration checking records the right dependencies (and any future logic that might want to perform direct operator lookups).
In doing so, this PR also removes the compatibility logic for the old referenced name tracker that would skip recording dependencies in certain cases. This should be safe as the new logic will record strictly more dependencies than the old logic.