Initial Infrastructure for "Private Intransitive" Dependencies #31568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This keeps us honest about the const-ness of the CompilerInstance itself: emitting diagnostics is a transitively mutating operation.
Add a flag to support setting the evaluator-based dependency collector in a mode that ignores scope inversions and only collects private dependencies.
|
@swift-ci smoke test and merge |
Add a mode bit to the dependency collector that respects the frontend flag in the previous commit. Notably, we now write over the dependency files at the end of the compiler pipeline when this flag is on so that dependency from SILGen and IRGen are properly written to disk.
CodaFi
force-pushed
the
this-is-a-private-party
branch
from
f6395d7 to
b06211e
Compare
|
@swift-ci smoke test |
|
@swift-ci test Windows |
|
⛵ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stands up a mode bit in the DependencyCollector and a new frontend and driver flag
-experimental-private-intransitive-dependenciesto support it. Reference dependencies and dependency verifier tests have been cloned to add the flag.This PR is ultimately incomplete. Driver tests remain to be cloned/updated, and no infrastructure to solve the batch-mode caching problem exists in this patchset. These are larger problems that deserve their own separate PRs.