Skip to content

Conversation

martinboehme
Copy link
Contributor

The copy and move assignment operators weren't returning anything and
were hence producing "non-void function does not return a value"
warnings.

As the test doesn't actually need a definition for these operators, I've
removed the definition and simply declared them.

The copy and move assignment operators weren't returning anything and
were hence producing "non-void function does not return a value"
warnings.

As the test doesn't actually need a definition for these operators, I've
removed the definition and simply declared them.
@martinboehme martinboehme requested a review from MForster May 20, 2020 06:11
@martinboehme
Copy link
Contributor Author

@swift-ci Please test

Copy link
Contributor

@MForster MForster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rjmccall rjmccall merged commit fe0bd4f into swiftlang:master May 20, 2020
@rjmccall
Copy link
Contributor

Seems reasonable enough to me.

@martinboehme martinboehme deleted the loadable-types-test-eliminate-warnings branch May 20, 2020 08:42
@gribozavr gribozavr added the c++ interop Feature: Interoperability with C++ label May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants