Skip to content

[Function builders] Infer function builder through @_dynamicReplacement(for:) #32248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 9, 2020
Merged

[Function builders] Infer function builder through @_dynamicReplacement(for:) #32248

merged 2 commits into from
Jun 9, 2020

Conversation

DougGregor
Copy link
Member

Fixes rdar://problem/63898120.

@DougGregor
Copy link
Member Author

@swift-ci please smoke test

hborla
hborla approved these changes Jun 8, 2020
View reviewed changes
Copy link
Member

@hborla hborla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One small question below (and perhaps a test should be added for that case):

@DougGregor
Copy link
Member Author

@swift-ci please smoke test and merge

1 similar comment
@DougGregor
Copy link
Member Author

@swift-ci please smoke test and merge

@swift-ci swift-ci merged commit e14cc4c into swiftlang:master Jun 9, 2020
@DougGregor DougGregor deleted the infer-function-builder-dynamic-replacement branch June 9, 2020 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xedin xedin xedin approved these changes

@hborla hborla hborla approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DougGregor @xedin @hborla @swift-ci