[5.3] AST: isEquivalentToExtendedContext() should consider use patterns of @_originallyDefinedIn #32665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…@_originallyDefinedIn When a nominal type and its extensions coexist in the same module, mangling may use the nominal type as the context for extension members. We should preserve this mechanism for types marked as @_originallyDefinedIn to maintain ABI stability. rdar://64538537
|
@swift-ci please test |
slavapestov
reviewed
Jul 1, 2020
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
@slavapestov Thank you for taking a look! The PR for addressing the code review comments was cherry-picked. |
tkremenek
approved these changes
Jul 2, 2020
AnthonyLatsis
added
swift 5.3
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a nominal type and its extensions coexist in the same module, mangling may
use the nominal type as the context for extension members. We should preserve this
mechanism for types marked as @_originallyDefinedIn to maintain ABI stability.
rdar://64538537