Skip to content

[5.3][Index] Fast path for getting value member #32749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2020

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Jul 7, 2020

Cherry-pick of #32748 into release/5.3

  • Explanation: Avoid solving constraint system if there's only one viable overload. This should fix a crash we are seeing in candidates.size() == 1 branch in the constraint system because the patch avoid the crashing code path.
  • Scope: Index while building, module interface printing
  • Risk: Very low. Just adding a fast path in obvious cases
  • Testing: Passes current regression test cases. No tests added because we don't have a reproducer of the crash
  • Issue: rdar://problem/64636688
  • Reviewer: Pavel Yaskevich (@xedin)

Avoid solving constraint system if there's only one viable overload.
This should also avoids a crash we are seeing in
'candidates.size() == 1' branch in the constraint system.

rdar://problem/64636688
(cherry picked from commit 0269049)
@rintaro rintaro requested a review from a team as a code owner July 7, 2020 22:15
@rintaro
Copy link
Member Author

rintaro commented Jul 7, 2020

@swift-ci Please test

@theblixguy theblixguy added the r5.3 label Jul 7, 2020
@rintaro
Copy link
Member Author

rintaro commented Jul 8, 2020

@swift-ci Please nominate

@rintaro rintaro merged commit ad727b4 into swiftlang:release/5.3 Jul 8, 2020
@AnthonyLatsis AnthonyLatsis added swift 5.3 🍒 release cherry pick Flag: Release branch cherry picks labels Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants