[Frontend] Improve -print-target-info #32758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…put. Clients that use -print-target-info can avoid an extra frontend invocation by using this information.
Describe the backward-deployment libraries via a preprocessor-driven table. Macro-metaprogramming the two places in the code base---the driver and IRGen---to use this tabble to determine which backward-compatibility libraries to link against.
The driver and any other client that attempts to properly link Swift code need to know which compatibility libraries should be linked on a per-target basis. Vend that information as part of -print-target-info.
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
Build failed |
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
Build failed |
|
Build failed |
|
@swift-ci test |
|
Build failed |
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility Release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance
-print-target-infoin a few ways to benefit the driver (and eliminate code duplication):-versionThe latter involved some refactoring into a table of compatibility libraries, since we already had 2 copies of the logic in the source code, and I would have had to add a third for
-print-target-info.