Skip to content

[ownership] Move ownership lowering past the eager specializer on the stdlib. #32835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gottesmm
Copy link
Contributor

Just doing the final bit.

@gottesmm
Copy link
Contributor Author

@swift-ci test source compatibility

@gottesmm
Copy link
Contributor Author

@swift-ci test

@gottesmm
Copy link
Contributor Author

@swift-ci benchmark

@swift-ci
Copy link
Contributor

Performance: -O

Code size: -O

Performance: -Osize

Regression OLD NEW DELTA RATIO
FlattenListLoop 1673 2469 +47.6% 0.68x (?)
FlattenListFlatMap 5510 6532 +18.5% 0.84x (?)

Code size: -Osize

Performance: -Onone

Code size: -swiftlibs

How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

@gottesmm
Copy link
Contributor Author

@swift-ci test compiler performance

@gottesmm
Copy link
Contributor Author

Just being careful around code-size. I should have done the smoke perf thing.

@gottesmm
Copy link
Contributor Author

Failure in the debug source compatibility is also happening on the bots.

@swift-ci
Copy link
Contributor

Summary for master full

Unexpected test results, excluded stats for RxCocoa, Backend

No regressions above thresholds

Debug-batch

debug-batch brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (3)
name old new delta delta_pct
Frontend.NumInstructionsExecuted 101,568,784,973,569 101,664,526,311,882 95,741,338,313 0.09%
LLVM.NumLLVMBytesOutput 1,599,440,658 1,599,440,130 -528 -0.0%
time.swift-driver.wall 7140.8s 7165.0s 24.2s 0.34%

debug-batch detailed

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (244)
name old new delta delta_pct
AST.ImportSetCacheHit 1,789,709 1,789,623 -86 -0.0%
AST.ImportSetCacheMiss 479,562 479,556 -6 -0.0%
AST.ImportSetFoldHit 159,408 159,409 1 0.0%
AST.ImportSetFoldMiss 320,154 320,147 -7 -0.0%
AST.ModuleShadowCacheHit 3,048 3,048 0 0.0%
AST.ModuleShadowCacheMiss 1,353 1,353 0 0.0%
AST.ModuleVisibilityCacheHit 37,763 37,763 0 0.0%
AST.ModuleVisibilityCacheMiss 9,651 9,651 0 0.0%
AST.NumASTBytesAllocated 44,298,245,902 44,298,047,850 -198,052 -0.0%
AST.NumASTScopeLookups 3,830,016 3,830,010 -6 -0.0%
AST.NumBraceStmtASTScopeExpansions 548,599 548,599 0 0.0%
AST.NumBraceStmtASTScopes 548,599 548,599 0 0.0%
AST.NumDecls 122,048 122,048 0 0.0%
AST.NumDependencies 308,090 308,091 1 0.0%
AST.NumIterableTypeBodyASTScopeExpansions 245,214 245,214 0 0.0%
AST.NumIterableTypeBodyASTScopes 309,473 309,483 10 0.0%
AST.NumLinkLibraries 0 0 0 0.0%
AST.NumLoadedModules 276,366 276,366 0 0.0%
AST.NumLocalTypeDecls 254 254 0 0.0%
AST.NumModuleLookupClassMember 7,008 7,008 0 0.0%
AST.NumModuleLookupValue 50,940,784 50,938,665 -2,119 -0.0%
AST.NumObjCMethods 24,768 24,768 0 0.0%
AST.NumOperators 683 683 0 0.0%
AST.NumPrecedenceGroups 122 122 0 0.0%
AST.NumReferencedDynamicNames 188 188 0 0.0%
AST.NumReferencedMemberNames 7,968,940 7,968,940 0 0.0%
AST.NumReferencedTopLevelNames 862,026 862,026 0 0.0%
AST.NumSourceBuffers 505,329 505,329 0 0.0%
AST.NumSourceLines 4,198,005 4,198,005 0 0.0%
AST.NumSourceLinesPerSecond 1,612,616 1,611,464 -1,152 -0.07%
AST.NumTotalClangImportedEntities 2,107,332 2,108,256 924 0.04%
Driver.ChildrenMaxRSS 244,687,777,792 244,199,569,408 -488,208,384 -0.2%
Driver.DriverDepCascadingDynamic 0 0 0 0.0%
Driver.DriverDepCascadingExternal 0 0 0 0.0%
Driver.DriverDepCascadingMember 0 0 0 0.0%
Driver.DriverDepCascadingNominal 0 0 0 0.0%
Driver.DriverDepCascadingTopLevel 0 0 0 0.0%
Driver.DriverDepDynamic 0 0 0 0.0%
Driver.DriverDepExternal 0 0 0 0.0%
Driver.DriverDepMember 0 0 0 0.0%
Driver.DriverDepNominal 0 0 0 0.0%
Driver.DriverDepTopLevel 0 0 0 0.0%
Driver.NumDriverJobsRun 24,308 24,308 0 0.0%
Driver.NumDriverJobsSkipped 0 0 0 0.0%
Driver.NumDriverPipePolls 74,454 74,205 -249 -0.33%
Driver.NumDriverPipeReads 64,573 64,382 -191 -0.3%
Driver.NumProcessFailures 0 0 0 0.0%
Frontend.MaxMallocUsage 1,612,095,909,304 1,612,914,603,424 818,694,120 0.05%
Frontend.NumInstructionsExecuted 101,568,784,973,569 101,664,526,311,882 95,741,338,313 0.09%
Frontend.NumProcessFailures 0 0 0 0.0%
IRGen.IRGenRequest 23,262 23,262 0 0.0%
IRModule.NumGOTEntries 193,525 193,525 0 0.0%
IRModule.NumIRAliases 177,131 177,131 0 0.0%
IRModule.NumIRBasicBlocks 5,928,256 5,928,256 0 0.0%
IRModule.NumIRComdatSymbols 0 0 0 0.0%
IRModule.NumIRFunctions 2,987,767 2,987,767 0 0.0%
IRModule.NumIRGlobals 3,305,614 3,305,614 0 0.0%
IRModule.NumIRIFuncs 0 0 0 0.0%
IRModule.NumIRInsts 79,386,184 79,386,184 0 0.0%
IRModule.NumIRNamedMetaData 117,910 117,910 0 0.0%
IRModule.NumIRValueSymbols 5,709,980 5,709,980 0 0.0%
LLVM.NumLLVMBytesOutput 1,599,440,658 1,599,440,130 -528 -0.0%
Parse.CodeCompletionSecondPassRequest 0 0 0 0.0%
Parse.NumFunctionsParsed 241,401 241,401 0 0.0%
Parse.NumIterableDeclContextParsed 840,591 840,593 2 0.0%
Parse.ParseAbstractFunctionBodyRequest 220,358 220,358 0 0.0%
Parse.ParseMembersRequest 694,610 694,612 2 0.0%
Parse.ParseSourceFileRequest 501,944 501,944 0 0.0%
SILGen.ASTLoweringRequest 24,303 24,303 0 0.0%
SILGen.ParseSILModuleRequest 0 0 0 0.0%
SILModule.NumSILGenDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILGenFunctions 1,838,903 1,838,903 0 0.0%
SILModule.NumSILGenGlobalVariables 46,241 46,241 0 0.0%
SILModule.NumSILGenVtables 29,036 29,036 0 0.0%
SILModule.NumSILGenWitnessTables 108,056 108,056 0 0.0%
SILModule.NumSILOptDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILOptFunctions 2,184,792 2,184,792 0 0.0%
SILModule.NumSILOptGlobalVariables 47,335 47,335 0 0.0%
SILModule.NumSILOptVtables 29,090 29,090 0 0.0%
SILModule.NumSILOptWitnessTables 139,209 139,209 0 0.0%
SILOptimizer.ExecuteSILPipelineRequest 94,149 94,149 0 0.0%
Sema.AbstractGenericSignatureRequest 37,898 37,898 0 0.0%
Sema.AccessLevelRequest 13,245,237 13,250,141 4,904 0.04%
Sema.AnyObjectLookupRequest 276 276 0 0.0%
Sema.AreAllStoredPropertiesDefaultInitableRequest 22,957 22,957 0 0.0%
Sema.AttachedFunctionBuilderRequest 303,345 303,345 0 0.0%
Sema.AttachedPropertyWrapperTypeRequest 507,863 507,863 0 0.0%
Sema.AttachedPropertyWrappersRequest 2,415,187 2,415,187 0 0.0%
Sema.CallerSideDefaultArgExprRequest 58,801 58,801 0 0.0%
Sema.CheckInconsistentImplementationOnlyImportsRequest 10,410 10,410 0 0.0%
Sema.CheckRedeclarationRequest 863,983 863,983 0 0.0%
Sema.ClassAncestryFlagsRequest 108,280 108,280 0 0.0%
Sema.ClosureHasExplicitResultRequest 78,716 78,716 0 0.0%
Sema.CodeCompletionFileRequest 0 0 0 0.0%
Sema.CollectOverriddenDeclsRequest 8,230,369 8,236,832 6,463 0.08%
Sema.CompareDeclSpecializationRequest 420,113 419,976 -137 -0.03%
Sema.CursorInfoRequest 0 0 0 0.0%
Sema.CustomAttrNominalRequest 574 574 0 0.0%
Sema.CustomAttrTypeRequest 351 351 0 0.0%
Sema.DefaultAndMaxAccessLevelRequest 52,824 52,824 0 0.0%
Sema.DefaultArgumentExprRequest 35,228 35,228 0 0.0%
Sema.DefaultArgumentInitContextRequest 210 210 0 0.0%
Sema.DefaultDefinitionTypeRequest 5,345 5,345 0 0.0%
Sema.DefaultTypeRequest 398,116 398,116 0 0.0%
Sema.DerivativeAttrOriginalDeclRequest 0 0 0 0.0%
Sema.DifferentiableAttributeTypeCheckRequest 0 0 0 0.0%
Sema.DirectLookupRequest 31,627,319 31,627,205 -114 -0.0%
Sema.DirectOperatorLookupRequest 1,873,704 1,873,657 -47 -0.0%
Sema.DirectPrecedenceGroupLookupRequest 555,288 555,288 0 0.0%
Sema.DynamicallyReplacedDeclRequest 968,251 968,251 0 0.0%
Sema.EmittedMembersRequest 26,275 26,275 0 0.0%
Sema.EnumRawTypeRequest 23,292 23,292 0 0.0%
Sema.EnumRawValuesRequest 9,560 9,560 0 0.0%
Sema.ExistentialConformsToSelfRequest 13,685 13,685 0 0.0%
Sema.ExistentialTypeSupportedRequest 15,476 15,476 0 0.0%
Sema.ExpandASTScopeRequest 6,919,243 6,919,249 6 0.0%
Sema.ExtendedNominalRequest 807,220 807,220 0 0.0%
Sema.ExtendedTypeRequest 76,674 76,674 0 0.0%
Sema.FragileFunctionKindRequest 1,666,118 1,666,118 0 0.0%
Sema.FunctionBuilderTypeRequest 302,969 302,969 0 0.0%
Sema.FunctionOperatorRequest 64,828 64,828 0 0.0%
Sema.GenericParamListRequest 9,762,168 9,764,773 2,605 0.03%
Sema.GenericSignatureRequest 2,383,504 2,383,435 -69 -0.0%
Sema.GetDestructorRequest 26,760 26,760 0 0.0%
Sema.HasCircularInheritanceRequest 22,559 22,559 0 0.0%
Sema.HasCircularInheritedProtocolsRequest 8,702 8,702 0 0.0%
Sema.HasCircularRawValueRequest 7,662 7,662 0 0.0%
Sema.HasDefaultInitRequest 51,606 51,606 0 0.0%
Sema.HasDynamicCallableAttributeRequest 0 0 0 0.0%
Sema.HasDynamicMemberLookupAttributeRequest 586,442 586,380 -62 -0.01%
Sema.HasImplementationOnlyImportsRequest 501,944 501,944 0 0.0%
Sema.HasMemberwiseInitRequest 16,592 16,592 0 0.0%
Sema.HasMissingDesignatedInitializersRequest 25,432 25,432 0 0.0%
Sema.HasUserDefinedDesignatedInitRequest 51,616 51,616 0 0.0%
Sema.InferredGenericSignatureRequest 178,206 178,206 0 0.0%
Sema.InheritedDeclsReferencedRequest 5,574,786 5,573,441 -1,345 -0.02%
Sema.InheritedProtocolsRequest 597,911 597,729 -182 -0.03%
Sema.InheritedTypeRequest 291,334 291,279 -55 -0.02%
Sema.InheritsSuperclassInitializersRequest 29,536 29,536 0 0.0%
Sema.InitKindRequest 90,113 90,113 0 0.0%
Sema.InterfaceTypeRequest 13,957,208 13,959,154 1,946 0.01%
Sema.IsABICompatibleOverrideRequest 122,524 122,524 0 0.0%
Sema.IsAccessorTransparentRequest 287,188 287,188 0 0.0%
Sema.IsCallableNominalTypeRequest 1,638 1,638 0 0.0%
Sema.IsDeclApplicableRequest 0 0 0 0.0%
Sema.IsDynamicRequest 1,532,206 1,532,206 0 0.0%
Sema.IsFinalRequest 2,630,338 2,630,044 -294 -0.01%
Sema.IsGetterMutatingRequest 389,066 389,066 0 0.0%
Sema.IsImplicitlyUnwrappedOptionalRequest 2,183,739 2,184,392 653 0.03%
Sema.IsObjCRequest 1,415,766 1,415,688 -78 -0.01%
Sema.IsSetterMutatingRequest 326,350 326,350 0 0.0%
Sema.IsStaticRequest 864,937 864,961 24 0.0%
Sema.LazyStoragePropertyRequest 2,820 2,820 0 0.0%
Sema.LookupAllConformancesInContextRequest 72,246 72,246 0 0.0%
Sema.LookupConformanceInModuleRequest 32,925,187 32,924,275 -912 -0.0%
Sema.LookupInModuleRequest 6,497,489 6,495,816 -1,673 -0.03%
Sema.LookupInfixOperatorRequest 75,165 75,165 0 0.0%
Sema.LookupPostfixOperatorRequest 215 215 0 0.0%
Sema.LookupPrecedenceGroupRequest 24,243 24,243 0 0.0%
Sema.LookupPrefixOperatorRequest 862 862 0 0.0%
Sema.MangleLocalTypeDeclRequest 508 508 0 0.0%
Sema.ModuleImplicitImportsRequest 11,431 11,431 0 0.0%
Sema.ModuleQualifiedLookupRequest 2,958,628 2,956,962 -1,666 -0.06%
Sema.NamedLazyMemberLoadSuccessCount 20,205,737 20,204,681 -1,056 -0.01%
Sema.NamingPatternRequest 209,782 209,782 0 0.0%
Sema.NeedsNewVTableEntryRequest 631,934 631,934 0 0.0%
Sema.NumAccessorBodiesSynthesized 166,629 166,629 0 0.0%
Sema.NumAccessorsSynthesized 267,192 267,192 0 0.0%
Sema.NumConformancesDeserialized 9,207,119 9,205,689 -1,430 -0.02%
Sema.NumConstraintScopes 27,783,850 27,783,760 -90 -0.0%
Sema.NumConstraintsConsideredForEdgeContraction 94,246,204 94,246,147 -57 -0.0%
Sema.NumCrossImportsChecked 0 0 0 0.0%
Sema.NumCrossImportsFound 0 0 0 0.0%
Sema.NumCyclicOneWayComponentsCollapsed 346 346 0 0.0%
Sema.NumDeclsDeserialized 74,635,162 74,635,259 97 0.0%
Sema.NumDeclsTypechecked 1,248,194 1,248,194 0 0.0%
Sema.NumGenericSignatureBuilders 1,181,757 1,181,486 -271 -0.02%
Sema.NumLazyIterableDeclContexts 8,905,464 8,903,329 -2,135 -0.02%
Sema.NumLazyRequirementSignatures 873,147 873,044 -103 -0.01%
Sema.NumLazyRequirementSignaturesLoaded 584,669 584,552 -117 -0.02%
Sema.NumLeafScopes 17,671,180 17,671,163 -17 -0.0%
Sema.NumTypesDeserialized 22,968,673 22,962,897 -5,776 -0.03%
Sema.NumUnloadedLazyIterableDeclContexts 5,666,903 5,665,131 -1,772 -0.03%
Sema.OpaqueReadOwnershipRequest 258,722 258,722 0 0.0%
Sema.OpaqueResultTypeRequest 206 206 0 0.0%
Sema.OperatorPrecedenceGroupRequest 784 784 0 0.0%
Sema.OverriddenDeclsRequest 2,458,021 2,459,476 1,455 0.06%
Sema.ParamSpecifierRequest 1,169,822 1,169,822 0 0.0%
Sema.PatternBindingEntryRequest 430,496 430,496 0 0.0%
Sema.PatternTypeRequest 491,443 491,443 0 0.0%
Sema.PreCheckFunctionBuilderRequest 330 330 0 0.0%
Sema.PrimarySourceFilesRequest 11,431 11,431 0 0.0%
Sema.PropertyWrapperBackingPropertyInfoRequest 501,849 501,849 0 0.0%
Sema.PropertyWrapperBackingPropertyTypeRequest 507,863 507,863 0 0.0%
Sema.PropertyWrapperLValuenessRequest 264 264 0 0.0%
Sema.PropertyWrapperMutabilityRequest 546,119 546,119 0 0.0%
Sema.PropertyWrapperTypeInfoRequest 119 119 0 0.0%
Sema.ProtocolRequiresClassRequest 39,982 39,949 -33 -0.08%
Sema.ProvideDefaultImplForRequest 8,230,369 8,236,832 6,463 0.08%
Sema.QualifiedLookupRequest 5,116,153 5,116,230 77 0.0%
Sema.RangeInfoRequest 0 0 0 0.0%
Sema.RequirementRequest 111,264 111,264 0 0.0%
Sema.RequirementSignatureRequest 645,210 645,034 -176 -0.03%
Sema.RequiresOpaqueAccessorsRequest 1,170,546 1,170,546 0 0.0%
Sema.RequiresOpaqueModifyCoroutineRequest 244,540 244,540 0 0.0%
Sema.ResolveEffectiveMemberwiseInitRequest 0 0 0 0.0%
Sema.ResolveImplicitMemberRequest 382,541 382,574 33 0.01%
Sema.ResolveProtocolNameRequest 0 0 0 0.0%
Sema.ResolveTypeEraserTypeRequest 0 0 0 0.0%
Sema.ResolveTypeRequest 3,338,058 3,338,058 0 0.0%
Sema.ResultTypeRequest 617,648 617,648 0 0.0%
Sema.RootAndResultTypeOfKeypathDynamicMemberRequest 0 0 0 0.0%
Sema.RootTypeOfKeypathDynamicMemberRequest 0 0 0 0.0%
Sema.SPIGroupsRequest 13,810,927 13,816,765 5,838 0.04%
Sema.ScopedImportLookupRequest 996 996 0 0.0%
Sema.SelfAccessKindRequest 604,341 604,359 18 0.0%
Sema.SelfBoundsFromWhereClauseRequest 1,797,820 1,797,061 -759 -0.04%
Sema.SetterAccessLevelRequest 127,038 127,038 0 0.0%
Sema.SimpleDidSetRequest 2,539,864 2,541,670 1,806 0.07%
Sema.StorageImplInfoRequest 1,294,863 1,294,863 0 0.0%
Sema.StoredPropertiesAndMissingMembersRequest 30,449 30,449 0 0.0%
Sema.StoredPropertiesRequest 321,888 321,888 0 0.0%
Sema.StructuralTypeRequest 1,679 1,679 0 0.0%
Sema.SuperclassDeclRequest 436,146 436,042 -104 -0.02%
Sema.SuperclassTypeRequest 55,553 55,553 0 0.0%
Sema.SynthesizeAccessorRequest 267,192 267,192 0 0.0%
Sema.SynthesizeDefaultInitRequest 5,173 5,173 0 0.0%
Sema.SynthesizeMainFunctionRequest 25,375 25,375 0 0.0%
Sema.SynthesizeMemberwiseInitRequest 3,113 3,113 0 0.0%
Sema.TangentStoredPropertyRequest 0 0 0 0.0%
Sema.TypeCheckFunctionBodyAtLocRequest 0 0 0 0.0%
Sema.TypeCheckFunctionBodyRequest 469,446 469,446 0 0.0%
Sema.TypeCheckSourceFileRequest 23,582 23,582 0 0.0%
Sema.TypeDeclsFromWhereClauseRequest 28,375 28,375 0 0.0%
Sema.TypeEraserHasViableInitRequest 0 0 0 0.0%
Sema.TypeRelationCheckRequest 0 0 0 0.0%
Sema.TypeWitnessRequest 8,836 8,836 0 0.0%
Sema.USRGenerationRequest 9,454,368 9,459,906 5,538 0.06%
Sema.UnderlyingTypeDeclsReferencedRequest 305,669 305,618 -51 -0.02%
Sema.UnderlyingTypeRequest 35,678 35,678 0 0.0%
Sema.UnqualifiedLookupRequest 3,957,810 3,957,804 -6 -0.0%
Sema.ValidatePrecedenceGroupRequest 158,758 158,758 0 0.0%
Sema.ValueWitnessRequest 60,915 60,915 0 0.0%
TBDGen.GenerateTBDRequest 23,282 23,282 0 0.0%

Release

release brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (3)
name old new delta delta_pct
Frontend.NumInstructionsExecuted 50,690,622,409,466 50,701,713,582,941 11,091,173,475 0.02%
LLVM.NumLLVMBytesOutput 1,570,972,256 1,570,970,688 -1,568 -0.0%
time.swift-driver.wall 9833.6s 9834.0s 358.0ms 0.0%

release detailed

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (16)
name old new delta delta_pct
AST.NumLoadedModules 21,335 21,335 0 0.0%
AST.NumTotalClangImportedEntities 431,234 431,234 0 0.0%
IRModule.NumIRBasicBlocks 4,015,130 4,015,130 0 0.0%
IRModule.NumIRFunctions 2,452,559 2,452,559 0 0.0%
IRModule.NumIRGlobals 2,956,505 2,956,505 0 0.0%
IRModule.NumIRInsts 42,104,891 42,104,891 0 0.0%
IRModule.NumIRValueSymbols 5,102,797 5,102,797 0 0.0%
LLVM.NumLLVMBytesOutput 1,570,972,256 1,570,970,688 -1,568 -0.0%
SILModule.NumSILGenFunctions 1,044,998 1,044,998 0 0.0%
SILModule.NumSILOptFunctions 884,684 884,684 0 0.0%
Sema.NumConformancesDeserialized 2,701,478 2,701,478 0 0.0%
Sema.NumConstraintScopes 28,154,041 28,154,041 0 0.0%
Sema.NumDeclsDeserialized 9,043,722 9,043,722 0 0.0%
Sema.NumGenericSignatureBuilders 198,418 198,418 0 0.0%
Sema.NumLazyIterableDeclContexts 1,144,023 1,144,023 0 0.0%
Sema.NumTypesDeserialized 4,324,440 4,324,440 0 0.0%

@gottesmm gottesmm merged commit 5be1585 into swiftlang:master Jul 12, 2020
@gottesmm gottesmm deleted the pr-719a3f1e89c7bed3246914b5ff52fd00d4486840 branch July 12, 2020 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants