AST: Allow @_fixed_layout protocols #32887
Merged
+61
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
force-pushed
the
fixed-layout-protocols
branch
from
c74d2c0 to
3af8c49
Compare
slavapestov
changed the title
slavapestov
force-pushed
the
fixed-layout-protocols
branch
from
3af8c49 to
c013ba5
Compare
|
@swift-ci please test |
|
Build failed |
slavapestov
force-pushed
the
fixed-layout-protocols
branch
from
c013ba5 to
70be07b
Compare
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
slavapestov
force-pushed
the
fixed-layout-protocols
branch
from
70be07b to
50d61e3
Compare
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
Build failed |
A @_fixed_layout protocol exposes its witness table layout to clients, which prevents re-ordering of requirements or adding new requiremenst with a default. When library evolution is enabled, we still emit method descriptors even for @_fixed_layout protocols; this allows a previously-resilient protocol to become @_fixed_layout as long as the published layout matches the resilient layout in all previously-shipped versions of the library.
slavapestov
force-pushed
the
fixed-layout-protocols
branch
from
50d61e3 to
4a47190
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A @_fixed_layout protocol exposes its witness table layout to
clients, which prevents re-ordering of requirements or adding
new requiremenst with a default.
When library evolution is enabled, we still emit method
descriptors even for @_fixed_layout protocols; this allows a
previously-resilient protocol to become @_fixed_layout as long
as the published layout matches the resilient layout in all
previously-shipped versions of the library.