Skip to content

[5.3] Revert "Merge pull request #32655 from benlangmuir/sema-repeat-53" #32889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2020
Merged

[5.3] Revert "Merge pull request #32655 from benlangmuir/sema-repeat-53" #32889

merged 1 commit into from
Jul 15, 2020

Conversation

benlangmuir
Copy link
Contributor

This reverts commit 46c6eee, reversing
changes made to eed09ea.

This caused an unexpected regression.

rdar://65554791

@benlangmuir
Revert "Merge pull request swiftlang#32655 from benlangmuir/sema-repe…
bba238b 
…at-53"

This reverts commit 46c6eee, reversing
changes made to eed09ea.

This caused an unexpecte regression.

rdar://65554791
@benlangmuir benlangmuir requested a review from a team as a code owner July 14, 2020 23:54
@benlangmuir
Copy link
Contributor Author

@swift-ci please test

@benlangmuir benlangmuir changed the title Revert "Merge pull request #32655 from benlangmuir/sema-repeat-53" [5.3] Revert "Merge pull request #32655 from benlangmuir/sema-repeat-53" Jul 15, 2020
@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - bba238b

@benlangmuir
Copy link
Contributor Author 

18:10:54 Failing Tests (1):
18:10:54     Swift(iphonesimulator-i386) :: Constraints/operator.swift`

Unrelated failure.

@benlangmuir
Copy link
Contributor Author

@swift-ci please test macOS

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - bba238b

@akyrtzi
Copy link
Contributor

akyrtzi commented Jul 15, 2020

@swift-ci please test macOS

@akyrtzi akyrtzi merged commit ef596b5 into swiftlang:release/5.3 Jul 15, 2020
@benlangmuir benlangmuir deleted the revert-sema-change branch July 15, 2020 15:58
@AnthonyLatsis AnthonyLatsis added swift 5.3 🍒 release cherry pick Flag: Release branch cherry picks labels Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akyrtzi akyrtzi akyrtzi approved these changes

Assignees
No one assigned
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@benlangmuir @swift-ci @akyrtzi @theblixguy @AnthonyLatsis