[Sema][os_log] Allow wrapping os_log strings within constant evaluable functions #32908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
Build failed |
|
This failure looks like some noise. |
|
@swift-ci Please test macOS Platform |
|
Build failed |
|
This time the error is different and is in LLDB test suite: Swift/astcontext_error.test. This is also noise. |
|
@swift-ci Please smoke test |
|
@swift-ci Please test macOS platform |
…e functions.
As of now, the sema checks for os_log allow only string interpolations to be passed
to the log calls. E.g. logger.log(foo("message")) would not be allowed. This PR
relaxes this requirement and allows it as long as foo is annotated as
@_semantics("constant_evaluable").
<rdar://problem/65842243>
ravikandhadai
force-pushed
the
SwiftUIPreviewFix-5.3
branch
from
3578d68 to
d827f58
Compare
|
Update the commit message to use the rdar problem for release/5.3 |
|
@swift-ci please test |
|
Build failed |
|
Build failed |
devincoughlin
approved these changes
Jul 21, 2020
AnthonyLatsis
added
swift 5.3
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of now, the sema checks for os_log allow only string interpolations to be passed to the log calls. E.g.
logger.log(foo("message"))would not be allowed. This PR relaxes this requirement and allows it as long asfoois annotated as@_semantics("constant_evaluable").However, as a special case, this PR still prevents calling the initializer of
OSLogMessage, which is annotated constant_evaluable, to create the log message. E.g.logger.log(OSLogMessage(stringLiteral: "message"))would still be prevented. This is done to ensure that users who are new to the APIs do not reach out for theOSLogMessageinitializer to construct a message (by looking at the type of the argument).OSLogMessageshould be automatically created when passing string interpolations. So this condition is checked for and a diagnostic is emitted.rdar://problem/65842243