-
Notifications
You must be signed in to change notification settings - Fork 10.5k
stdlib: remove _Reflectable #3313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci Please test |
@swift-ci Please benchmark |
Build comment file:Optimized (O)
|
TEST | OLD_MIN | NEW_MIN | DELTA (%) | SPEEDUP |
---|---|---|---|---|
NSStringConversion | 660 | 839 | +27.1% | 0.79x |
ErrorHandling | 3105 | 3415 | +10.0% | 0.91x |
ObjectiveCBridgeFromNSString | 1704 | 1870 | +9.7% | 0.91x |
ClassArrayGetter | 14 | 15 | +7.1% | 0.93x |
ObjectAllocation | 153 | 164 | +7.2% | 0.93x |
ObjectiveCBridgeStubFromArrayOfNSString | 146387 | 156353 | +6.8% | 0.94x |
Improvement (1)
TEST | OLD_MIN | NEW_MIN | DELTA (%) | SPEEDUP |
---|---|---|---|---|
ObjectiveCBridgeFromNSArrayAnyObjectForced | 4708 | 3843 | -18.4% | 1.23x |
No Changes (127)
TEST | OLD_MIN | NEW_MIN | DELTA (%) | SPEEDUP |
---|---|---|---|---|
ObjectiveCBridgeFromNSDictionaryAnyObjectToString | 315165 | 299022 | -5.1% | 1.05x |
ObjectiveCBridgeStubToNSDate | 13933 | 13378 | -4.0% | 1.04x(?) |
ObjectiveCBridgeFromNSSetAnyObjectForced | 4362 | 4211 | -3.5% | 1.04x |
ObjectiveCBridgeStubToNSString | 1320 | 1279 | -3.1% | 1.03x |
ObjectiveCBridgeFromNSSetAnyObject | 130112 | 126121 | -3.1% | 1.03x(?) |
ObjectiveCBridgeToNSArray | 34138 | 33209 | -2.7% | 1.03x |
ObjectiveCBridgeStubToNSStringRef | 141 | 137 | -2.8% | 1.03x |
ObjectiveCBridgeFromNSDictionaryAnyObjectForced | 4980 | 4862 | -2.4% | 1.02x(?) |
StringInterpolation | 12096 | 11806 | -2.4% | 1.02x |
ObjectiveCBridgeStubFromNSString | 791 | 773 | -2.3% | 1.02x |
ObjectiveCBridgeStubToNSDateRef | 3359 | 3279 | -2.4% | 1.02x |
ObjectiveCBridgeFromNSDictionaryAnyObjectToStringForced | 186871 | 182469 | -2.4% | 1.02x(?) |
Dictionary2OfObjects | 3370 | 3317 | -1.6% | 1.02x(?) |
ArraySubscript | 1402 | 1389 | -0.9% | 1.01x(?) |
ObjectiveCBridgeToNSString | 1078 | 1069 | -0.8% | 1.01x |
StrComplexWalk | 3783 | 3735 | -1.3% | 1.01x(?) |
AngryPhonebook | 2907 | 2888 | -0.7% | 1.01x(?) |
PopFrontArrayGeneric | 1901 | 1877 | -1.3% | 1.01x |
ObjectiveCBridgeStubURLAppendPath | 277520 | 275848 | -0.6% | 1.01x(?) |
ObjectiveCBridgeStubToArrayOfNSString | 32884 | 32633 | -0.8% | 1.01x(?) |
ObjectiveCBridgeStubDataAppend | 3094 | 3075 | -0.6% | 1.01x(?) |
ObjectiveCBridgeFromNSSetAnyObjectToStringForced | 148558 | 147592 | -0.7% | 1.01x(?) |
Chars | 707 | 703 | -0.6% | 1.01x |
ObjectiveCBridgeStubNSDataAppend | 2577 | 2540 | -1.4% | 1.01x(?) |
DictionarySwapOfObjects | 6926 | 6927 | +0.0% | 1.00x(?) |
StackPromo | 20040 | 20037 | -0.0% | 1.00x(?) |
RecursiveOwnedParameter | 1990 | 1989 | -0.1% | 1.00x(?) |
Integrate | 249 | 248 | -0.4% | 1.00x |
Array2D | 2808 | 2798 | -0.4% | 1.00x(?) |
Histogram | 675 | 675 | +0.0% | 1.00x |
SortStrings | 1950 | 1952 | +0.1% | 1.00x(?) |
ObjectiveCBridgeStubFromNSDateRef | 3968 | 3967 | -0.0% | 1.00x(?) |
MonteCarloPi | 44237 | 44362 | +0.3% | 1.00x(?) |
StringWithCString | 648059 | 647993 | -0.0% | 1.00x(?) |
ObjectiveCBridgeFromNSStringForced | 2412 | 2407 | -0.2% | 1.00x(?) |
Prims | 741 | 742 | +0.1% | 1.00x(?) |
SortLettersInPlace | 993 | 995 | +0.2% | 1.00x(?) |
DictionarySwap | 812 | 811 | -0.1% | 1.00x(?) |
ArrayOfGenericPOD | 222 | 222 | +0.0% | 1.00x |
Dictionary3OfObjects | 897 | 900 | +0.3% | 1.00x |
ByteSwap | 1 | 1 | +0.0% | 1.00x |
SuperChars | 509405 | 510887 | +0.3% | 1.00x |
XorLoop | 406 | 407 | +0.2% | 1.00x |
ObjectiveCBridgeStubFromNSStringRef | 153 | 153 | +0.0% | 1.00x |
ProtocolDispatch | 3160 | 3157 | -0.1% | 1.00x(?) |
TypeFlood | 0 | 0 | +0.0% | 1.00x |
ProtocolDispatch2 | 147 | 147 | +0.0% | 1.00x |
HashTest | 2075 | 2070 | -0.2% | 1.00x(?) |
Dictionary3 | 541 | 542 | +0.2% | 1.00x(?) |
Dictionary2 | 1962 | 1963 | +0.1% | 1.00x(?) |
StringHasPrefix | 832 | 832 | +0.0% | 1.00x |
SetIntersect_OfObjects | 2460 | 2470 | +0.4% | 1.00x(?) |
Join | 477 | 477 | +0.0% | 1.00x |
ObjectiveCBridgeStubDateMutation | 258 | 258 | +0.0% | 1.00x |
NSError | 337 | 338 | +0.3% | 1.00x |
PopFrontUnsafePointer | 9104 | 9096 | -0.1% | 1.00x(?) |
StringEqualPointerComparison | 8383 | 8384 | +0.0% | 1.00x(?) |
CaptureProp | 4879 | 4878 | -0.0% | 1.00x(?) |
PolymorphicCalls | 74 | 74 | +0.0% | 1.00x |
RC4 | 243 | 244 | +0.4% | 1.00x |
Calculator | 41 | 41 | +0.0% | 1.00x |
MapReduce | 423 | 423 | +0.0% | 1.00x |
Hanoi | 3749 | 3757 | +0.2% | 1.00x(?) |
OpenClose | 68 | 68 | +0.0% | 1.00x |
DictionaryRemoveOfObjects | 20611 | 20698 | +0.4% | 1.00x(?) |
UTF8Decode | 395 | 396 | +0.2% | 1.00x |
SortStringsUnicode | 10183 | 10228 | +0.4% | 1.00x |
SetIsSubsetOf | 520 | 520 | +0.0% | 1.00x |
Dictionary | 808 | 806 | -0.2% | 1.00x(?) |
NopDeinit | 36857 | 36783 | -0.2% | 1.00x |
SetIntersect | 1266 | 1262 | -0.3% | 1.00x(?) |
SetExclusiveOr | 3928 | 3920 | -0.2% | 1.00x(?) |
ObjectiveCBridgeStubNSDateRefAccess | 383 | 382 | -0.3% | 1.00x |
StrToInt | 5657 | 5662 | +0.1% | 1.00x(?) |
ArrayInClass | 96 | 96 | +0.0% | 1.00x |
StringHasSuffix | 947 | 947 | +0.0% | 1.00x |
Phonebook | 7923 | 7923 | +0.0% | 1.00x |
ObjectiveCBridgeStubDateAccess | 229 | 229 | +0.0% | 1.00x |
Sim2DArray | 510 | 510 | +0.0% | 1.00x |
MonteCarloE | 10389 | 10394 | +0.1% | 1.00x(?) |
StringHasSuffixUnicode | 75697 | 75369 | -0.4% | 1.00x |
Walsh | 365 | 365 | +0.0% | 1.00x |
SetIsSubsetOf_OfObjects | 664 | 664 | +0.0% | 1.00x |
ArrayAppend | 764 | 767 | +0.4% | 1.00x(?) |
DictionaryRemove | 5001 | 5004 | +0.1% | 1.00x(?) |
StringHasPrefixUnicode | 16935 | 17011 | +0.5% | 1.00x(?) |
LinkedList | 6438 | 6456 | +0.3% | 1.00x(?) |
RGBHistogramOfObjects | 22949 | 23033 | +0.4% | 1.00x(?) |
RGBHistogram | 3250 | 3234 | -0.5% | 1.00x(?) |
ArrayValueProp4 | 8 | 8 | +0.0% | 1.00x |
SetUnion | 3699 | 3696 | -0.1% | 1.00x(?) |
StringBuilder | 1563 | 1563 | +0.0% | 1.00x |
DeadArray | 201 | 200 | -0.5% | 1.00x |
BitCount | 1 | 1 | +0.0% | 1.00x |
SevenBoom | 1376 | 1375 | -0.1% | 1.00x(?) |
StringWalk | 8121 | 8119 | -0.0% | 1.00x(?) |
ArrayValueProp | 8 | 8 | +0.0% | 1.00x |
GlobalClass | 0 | 0 | +0.0% | 1.00x |
Memset | 214 | 213 | -0.5% | 1.00x(?) |
ArrayAppendReserved | 516 | 517 | +0.2% | 1.00x(?) |
TwoSum | 1945 | 1945 | +0.0% | 1.00x |
ArrayValueProp2 | 8 | 8 | +0.0% | 1.00x |
ArrayValueProp3 | 8 | 8 | +0.0% | 1.00x |
ObjectiveCBridgeStubFromNSDate | 3832 | 3831 | -0.0% | 1.00x(?) |
PopFrontArray | 1885 | 1898 | +0.7% | 0.99x(?) |
StaticArray | 2959 | 2984 | +0.8% | 0.99x(?) |
ArrayOfRef | 3531 | 3557 | +0.7% | 0.99x(?) |
DictionaryOfObjects | 2279 | 2293 | +0.6% | 0.99x |
NSDictionaryCastToSwift | 13551 | 13677 | +0.9% | 0.99x(?) |
SetExclusiveOr_OfObjects | 8643 | 8721 | +0.9% | 0.99x(?) |
SetUnion_OfObjects | 7217 | 7267 | +0.7% | 0.99x(?) |
ArrayOfPOD | 184 | 185 | +0.5% | 0.99x |
ArrayLiteral | 1014 | 1020 | +0.6% | 0.99x |
ObjectiveCBridgeStubNSDateMutationRef | 12183 | 12252 | +0.6% | 0.99x(?) |
ObjectiveCBridgeFromNSDictionaryAnyObject | 308619 | 315065 | +2.1% | 0.98x |
DictionaryBridge | 5853 | 6003 | +2.6% | 0.98x(?) |
133 | 4394864 | 4466303 | +1.6% | 0.98x |
ObjectiveCBridgeStubURLAppendPathRef | 285613 | 291272 | +2.0% | 0.98x(?) |
ObjectiveCBridgeFromNSArrayAnyObject | 69239 | 70594 | +2.0% | 0.98x(?) |
ArrayOfGenericRef | 3602 | 3674 | +2.0% | 0.98x |
ObjectiveCBridgeFromNSArrayAnyObjectToString | 197646 | 203927 | +3.2% | 0.97x(?) |
DictionaryLiteral | 4354 | 4484 | +3.0% | 0.97x(?) |
RangeAssignment | 377 | 391 | +3.7% | 0.96x(?) |
ObjectiveCBridgeToNSSet | 22231 | 23081 | +3.8% | 0.96x(?) |
ObjectiveCBridgeFromNSSetAnyObjectToString | 199636 | 208929 | +4.7% | 0.96x |
ObjectiveCBridgeToNSDictionary | 24205 | 25532 | +5.5% | 0.95x(?) |
ObjectiveCBridgeFromNSArrayAnyObjectToStringForced | 198233 | 207891 | +4.9% | 0.95x |
Regression (4)
TEST | OLD_MIN | NEW_MIN | DELTA (%) | SPEEDUP |
---|---|---|---|---|
Chars | 5821 | 6669 | +14.6% | 0.87x |
ObjectiveCBridgeStubFromArrayOfNSString | 136544 | 153434 | +12.4% | 0.89x(?) |
ObjectiveCBridgeToNSDictionary | 22822 | 24928 | +9.2% | 0.92x |
NSStringConversion | 2873 | 3092 | +7.6% | 0.93x(?) |
Improvement (5)
TEST | OLD_MIN | NEW_MIN | DELTA (%) | SPEEDUP |
---|---|---|---|---|
Histogram | 15838 | 14982 | -5.4% | 1.06x(?) |
ObjectiveCBridgeStubFromNSString | 856 | 810 | -5.4% | 1.06x(?) |
SetIntersect | 21961 | 20779 | -5.4% | 1.06x |
ObjectiveCBridgeFromNSSetAnyObjectForced | 9410 | 8524 | -9.4% | 1.10x(?) |
ObjectiveCBridgeToNSSet | 24422 | 21445 | -12.2% | 1.14x(?) |
No Changes (125)
TEST | OLD_MIN | NEW_MIN | DELTA (%) | SPEEDUP |
---|---|---|---|---|
Dictionary3OfObjects | 2922 | 2786 | -4.7% | 1.05x(?) |
DictionarySwap | 12271 | 11853 | -3.4% | 1.04x |
ObjectiveCBridgeFromNSDictionaryAnyObjectToStringForced | 189555 | 182317 | -3.8% | 1.04x(?) |
SetIsSubsetOf | 3377 | 3246 | -3.9% | 1.04x |
PopFrontArray | 26977 | 25935 | -3.9% | 1.04x(?) |
ArrayOfPOD | 2520 | 2413 | -4.2% | 1.04x |
StackPromo | 126819 | 123524 | -2.6% | 1.03x(?) |
SortStrings | 2847 | 2773 | -2.6% | 1.03x |
ArrayOfGenericPOD | 4270 | 4141 | -3.0% | 1.03x |
NopDeinit | 63422 | 61686 | -2.7% | 1.03x(?) |
ObjectiveCBridgeStubNSDateMutationRef | 14574 | 14157 | -2.9% | 1.03x(?) |
RGBHistogram | 57044 | 55389 | -2.9% | 1.03x(?) |
ObjectiveCBridgeFromNSDictionaryAnyObjectToString | 319091 | 314225 | -1.5% | 1.02x |
ObjectiveCBridgeFromNSArrayAnyObjectForced | 7998 | 7868 | -1.6% | 1.02x(?) |
ObjectiveCBridgeToNSArray | 33429 | 32803 | -1.9% | 1.02x(?) |
OpenClose | 482 | 473 | -1.9% | 1.02x |
NSDictionaryCastToSwift | 16142 | 15832 | -1.9% | 1.02x(?) |
StringHasPrefixUnicode | 18578 | 18242 | -1.8% | 1.02x(?) |
ArraySubscript | 5837 | 5807 | -0.5% | 1.01x(?) |
DictionarySwapOfObjects | 26983 | 26633 | -1.3% | 1.01x(?) |
ObjectiveCBridgeFromNSStringForced | 2883 | 2847 | -1.2% | 1.01x(?) |
StringInterpolation | 16926 | 16804 | -0.7% | 1.01x(?) |
ObjectiveCBridgeStubToNSString | 1367 | 1360 | -0.5% | 1.01x(?) |
TypeFlood | 158 | 156 | -1.3% | 1.01x(?) |
AngryPhonebook | 3800 | 3758 | -1.1% | 1.01x |
Dictionary3 | 2152 | 2141 | -0.5% | 1.01x(?) |
DictionaryOfObjects | 5965 | 5892 | -1.2% | 1.01x(?) |
ObjectiveCBridgeStubToNSDateRef | 3325 | 3308 | -0.5% | 1.01x(?) |
ObjectiveCBridgeStubToNSStringRef | 178 | 177 | -0.6% | 1.01x(?) |
DictionaryLiteral | 24366 | 24208 | -0.7% | 1.01x(?) |
DictionaryRemoveOfObjects | 65547 | 65212 | -0.5% | 1.01x |
SortStringsUnicode | 11312 | 11180 | -1.2% | 1.01x |
SetExclusiveOr | 50043 | 49555 | -1.0% | 1.01x(?) |
RGBHistogramOfObjects | 106500 | 105591 | -0.8% | 1.01x(?) |
ArrayLiteral | 1132 | 1124 | -0.7% | 1.01x |
ObjectiveCBridgeFromNSString | 5306 | 5252 | -1.0% | 1.01x(?) |
Dictionary2OfObjects | 7392 | 7354 | -0.5% | 1.01x(?) |
TwoSum | 10202 | 10133 | -0.7% | 1.01x(?) |
ObjectiveCBridgeToNSString | 1108 | 1109 | +0.1% | 1.00x(?) |
MonteCarloPi | 53729 | 53708 | -0.0% | 1.00x(?) |
RecursiveOwnedParameter | 8176 | 8167 | -0.1% | 1.00x(?) |
Integrate | 366 | 367 | +0.3% | 1.00x(?) |
ClassArrayGetter | 1338 | 1338 | +0.0% | 1.00x |
Array2D | 842268 | 842131 | -0.0% | 1.00x(?) |
DictionaryBridge | 6108 | 6108 | +0.0% | 1.00x |
ObjectiveCBridgeStubFromNSDateRef | 4283 | 4286 | +0.1% | 1.00x(?) |
StringWithCString | 825381 | 825791 | +0.1% | 1.00x(?) |
SortLettersInPlace | 2592 | 2594 | +0.1% | 1.00x(?) |
RangeAssignment | 23649 | 23694 | +0.2% | 1.00x(?) |
StringHasPrefix | 1837 | 1837 | +0.0% | 1.00x |
ByteSwap | 10 | 10 | +0.0% | 1.00x |
SuperChars | 552433 | 550701 | -0.3% | 1.00x(?) |
ObjectiveCBridgeStubToNSDate | 14393 | 14377 | -0.1% | 1.00x(?) |
XorLoop | 21601 | 21701 | +0.5% | 1.00x |
ObjectiveCBridgeStubFromNSStringRef | 188 | 188 | +0.0% | 1.00x |
ProtocolDispatch | 6477 | 6476 | -0.0% | 1.00x(?) |
ObjectAllocation | 561 | 561 | +0.0% | 1.00x |
StringHasSuffixUnicode | 76831 | 76832 | +0.0% | 1.00x(?) |
ProtocolDispatch2 | 460 | 459 | -0.2% | 1.00x |
HashTest | 5660 | 5648 | -0.2% | 1.00x(?) |
SetIntersect_OfObjects | 20198 | 20163 | -0.2% | 1.00x(?) |
Join | 1512 | 1515 | +0.2% | 1.00x(?) |
ArrayOfRef | 9305 | 9340 | +0.4% | 1.00x(?) |
ObjectiveCBridgeStubURLAppendPathRef | 288089 | 287841 | -0.1% | 1.00x(?) |
ObjectiveCBridgeStubDateMutation | 517 | 516 | -0.2% | 1.00x |
PopFrontArrayGeneric | 11897 | 11886 | -0.1% | 1.00x(?) |
PopFrontUnsafePointer | 263930 | 263687 | -0.1% | 1.00x(?) |
CaptureProp | 130735 | 130874 | +0.1% | 1.00x(?) |
Calculator | 1029 | 1031 | +0.2% | 1.00x(?) |
MapReduce | 46066 | 46132 | +0.1% | 1.00x(?) |
Hanoi | 20073 | 20153 | +0.4% | 1.00x(?) |
UTF8Decode | 44093 | 44106 | +0.0% | 1.00x(?) |
Dictionary | 2892 | 2895 | +0.1% | 1.00x(?) |
ObjectiveCBridgeStubDataAppend | 3503 | 3501 | -0.1% | 1.00x(?) |
ObjectiveCBridgeStubNSDateRefAccess | 1297 | 1299 | +0.1% | 1.00x(?) |
StrToInt | 6037 | 6030 | -0.1% | 1.00x(?) |
ArrayInClass | 4134 | 4150 | +0.4% | 1.00x |
ArrayOfGenericRef | 9992 | 10000 | +0.1% | 1.00x(?) |
StringHasSuffix | 1981 | 1982 | +0.1% | 1.00x(?) |
Phonebook | 62294 | 62403 | +0.2% | 1.00x(?) |
ObjectiveCBridgeStubDateAccess | 1121 | 1119 | -0.2% | 1.00x(?) |
Sim2DArray | 16562 | 16567 | +0.0% | 1.00x(?) |
SetExclusiveOr_OfObjects | 69863 | 69851 | -0.0% | 1.00x(?) |
MonteCarloE | 111781 | 111929 | +0.1% | 1.00x(?) |
SetUnion_OfObjects | 52660 | 52748 | +0.2% | 1.00x(?) |
GlobalClass | 0 | 0 | +0.0% | 1.00x |
Walsh | 13542 | 13505 | -0.3% | 1.00x(?) |
ArrayAppend | 3644 | 3643 | -0.0% | 1.00x(?) |
DictionaryRemove | 33138 | 33106 | -0.1% | 1.00x(?) |
SetUnion | 34359 | 34250 | -0.3% | 1.00x(?) |
DeadArray | 131870 | 131339 | -0.4% | 1.00x(?) |
BitCount | 120 | 120 | +0.0% | 1.00x |
ArrayValueProp3 | 2918 | 2912 | -0.2% | 1.00x(?) |
StringWalk | 26424 | 26466 | +0.2% | 1.00x |
ArrayValueProp | 2379 | 2383 | +0.2% | 1.00x(?) |
RC4 | 9187 | 9188 | +0.0% | 1.00x(?) |
ArrayValueProp4 | 2849 | 2849 | +0.0% | 1.00x |
ObjectiveCBridgeStubNSDataAppend | 4864 | 4881 | +0.3% | 1.00x |
SevenBoom | 1504 | 1510 | +0.4% | 1.00x(?) |
ObjectiveCBridgeStubFromNSDate | 4215 | 4213 | -0.1% | 1.00x(?) |
133 | 7398878 | 7447327 | +0.7% | 0.99x |
ObjectiveCBridgeFromNSArrayAnyObjectToString | 203843 | 206175 | +1.1% | 0.99x(?) |
Prims | 15326 | 15436 | +0.7% | 0.99x(?) |
Dictionary2 | 5412 | 5441 | +0.5% | 0.99x(?) |
StrComplexWalk | 9994 | 10086 | +0.9% | 0.99x(?) |
StringEqualPointerComparison | 11024 | 11088 | +0.6% | 0.99x |
ObjectiveCBridgeStubURLAppendPath | 282119 | 285668 | +1.3% | 0.99x(?) |
LinkedList | 27477 | 27650 | +0.6% | 0.99x(?) |
StringBuilder | 2856 | 2897 | +1.4% | 0.99x(?) |
ArrayValueProp2 | 2852 | 2867 | +0.5% | 0.99x(?) |
Memset | 20922 | 21130 | +1.0% | 0.99x |
StaticArray | 31953 | 32648 | +2.2% | 0.98x(?) |
ObjectiveCBridgeFromNSSetAnyObject | 138164 | 141007 | +2.1% | 0.98x(?) |
ObjectiveCBridgeStubToArrayOfNSString | 32181 | 32953 | +2.4% | 0.98x(?) |
ArrayAppendReserved | 3375 | 3444 | +2.0% | 0.98x |
NSError | 644 | 664 | +3.1% | 0.97x(?) |
PolymorphicCalls | 1168 | 1198 | +2.6% | 0.97x(?) |
SetIsSubsetOf_OfObjects | 3093 | 3189 | +3.1% | 0.97x(?) |
ObjectiveCBridgeFromNSDictionaryAnyObject | 313778 | 326611 | +4.1% | 0.96x |
ErrorHandling | 3859 | 4021 | +4.2% | 0.96x(?) |
ObjectiveCBridgeFromNSArrayAnyObject | 75286 | 78458 | +4.2% | 0.96x(?) |
ObjectiveCBridgeFromNSSetAnyObjectToString | 210645 | 219454 | +4.2% | 0.96x(?) |
ObjectiveCBridgeFromNSSetAnyObjectToStringForced | 155358 | 162227 | +4.4% | 0.96x(?) |
ObjectiveCBridgeFromNSArrayAnyObjectToStringForced | 198887 | 206874 | +4.0% | 0.96x(?) |
ObjectiveCBridgeFromNSDictionaryAnyObjectForced | 8680 | 9092 | +4.8% | 0.95x(?) |
@swift-ci Please benchmark |
Build comment file:Optimized (O)
|
TEST | OLD_MIN | NEW_MIN | DELTA (%) | SPEEDUP |
---|---|---|---|---|
SortLettersInPlace | 955 | 1202 | +25.9% | 0.79x |
ProtocolDispatch2 | 156 | 189 | +21.1% | 0.83x |
ObjectiveCBridgeStubToArrayOfNSString | 30378 | 36775 | +21.1% | 0.83x |
RangeAssignment | 327 | 388 | +18.6% | 0.84x |
ObjectiveCBridgeStubToNSDate | 12695 | 15151 | +19.4% | 0.84x |
ObjectiveCBridgeStubNSDateRefAccess | 330 | 385 | +16.7% | 0.86x |
Sim2DArray | 382 | 430 | +12.6% | 0.89x(?) |
ObjectiveCBridgeFromNSStringForced | 2270 | 2513 | +10.7% | 0.90x(?) |
SetIntersect | 1147 | 1275 | +11.2% | 0.90x |
Integrate | 244 | 267 | +9.4% | 0.91x(?) |
ObjectiveCBridgeStubToNSDateRef | 3272 | 3596 | +9.9% | 0.91x |
SetExclusiveOr | 3769 | 4127 | +9.5% | 0.91x |
RGBHistogramOfObjects | 21894 | 24044 | +9.8% | 0.91x |
RGBHistogram | 3123 | 3427 | +9.7% | 0.91x |
SortStrings | 1801 | 1952 | +8.4% | 0.92x |
PopFrontArrayGeneric | 1135 | 1239 | +9.2% | 0.92x(?) |
PopFrontUnsafePointer | 8847 | 9619 | +8.7% | 0.92x |
PolymorphicCalls | 60 | 65 | +8.3% | 0.92x |
ObjectiveCBridgeToNSDictionary | 16468 | 17865 | +8.5% | 0.92x |
SetUnion_OfObjects | 7084 | 7659 | +8.1% | 0.92x |
SetUnion | 3354 | 3648 | +8.8% | 0.92x |
RecursiveOwnedParameter | 1830 | 1965 | +7.4% | 0.93x |
Prims | 745 | 802 | +7.7% | 0.93x(?) |
ObjectiveCBridgeStubURLAppendPathRef | 205754 | 221781 | +7.8% | 0.93x(?) |
ObjectiveCBridgeStubNSDataAppend | 2335 | 2505 | +7.3% | 0.93x(?) |
ObjectiveCBridgeToNSString | 1066 | 1129 | +5.9% | 0.94x |
ProtocolDispatch | 2986 | 3161 | +5.9% | 0.94x(?) |
DictionaryLiteral | 4453 | 4722 | +6.0% | 0.94x |
OpenClose | 50 | 53 | +6.0% | 0.94x |
DeadArray | 182 | 194 | +6.6% | 0.94x |
RC4 | 245 | 261 | +6.5% | 0.94x |
Improvement (2)
TEST | OLD_MIN | NEW_MIN | DELTA (%) | SPEEDUP |
---|---|---|---|---|
MapReduce | 405 | 375 | -7.4% | 1.08x |
SuperChars | 398677 | 363743 | -8.8% | 1.10x |
No Changes (101)
TEST | OLD_MIN | NEW_MIN | DELTA (%) | SPEEDUP |
---|---|---|---|---|
Array2D | 2069 | 1992 | -3.7% | 1.04x(?) |
DictionaryBridge | 3929 | 3823 | -2.7% | 1.03x |
Walsh | 327 | 318 | -2.8% | 1.03x(?) |
ObjectiveCBridgeToNSSet | 16891 | 16627 | -1.6% | 1.02x(?) |
CaptureProp | 4213 | 4150 | -1.5% | 1.02x(?) |
StringHasSuffixUnicode | 65529 | 64503 | -1.6% | 1.02x(?) |
Histogram | 661 | 656 | -0.8% | 1.01x(?) |
ObjectiveCBridgeFromNSDictionaryAnyObjectForced | 4688 | 4640 | -1.0% | 1.01x(?) |
DictionarySwap | 766 | 761 | -0.7% | 1.01x(?) |
ObjectiveCBridgeFromNSString | 1655 | 1631 | -1.4% | 1.01x(?) |
StringHasPrefix | 657 | 652 | -0.8% | 1.01x(?) |
ObjectiveCBridgeFromNSSetAnyObject | 112486 | 111271 | -1.1% | 1.01x(?) |
Dictionary2 | 1903 | 1886 | -0.9% | 1.01x(?) |
NSError | 328 | 325 | -0.9% | 1.01x(?) |
UTF8Decode | 311 | 309 | -0.6% | 1.01x(?) |
NSStringConversion | 602 | 596 | -1.0% | 1.01x(?) |
ObjectiveCBridgeStubFromArrayOfNSString | 112991 | 111743 | -1.1% | 1.01x(?) |
ArraySubscript | 1343 | 1346 | +0.2% | 1.00x(?) |
DictionarySwapOfObjects | 6681 | 6686 | +0.1% | 1.00x(?) |
ClassArrayGetter | 12 | 12 | +0.0% | 1.00x |
MonteCarloPi | 42514 | 42549 | +0.1% | 1.00x(?) |
StringWithCString | 586909 | 587076 | +0.0% | 1.00x(?) |
ObjectiveCBridgeFromNSArrayAnyObjectForced | 3770 | 3753 | -0.5% | 1.00x(?) |
Dictionary3OfObjects | 880 | 876 | -0.5% | 1.00x(?) |
ByteSwap | 1 | 1 | +0.0% | 1.00x |
XorLoop | 360 | 361 | +0.3% | 1.00x |
StringInterpolation | 11567 | 11574 | +0.1% | 1.00x(?) |
ObjectAllocation | 149 | 149 | +0.0% | 1.00x |
TypeFlood | 0 | 0 | +0.0% | 1.00x |
StrComplexWalk | 3144 | 3134 | -0.3% | 1.00x(?) |
ErrorHandling | 3057 | 3053 | -0.1% | 1.00x(?) |
ObjectiveCBridgeStubDateMutation | 268 | 267 | -0.4% | 1.00x(?) |
Calculator | 34 | 34 | +0.0% | 1.00x |
ArrayOfGenericPOD | 208 | 208 | +0.0% | 1.00x |
DictionaryRemoveOfObjects | 20181 | 20094 | -0.4% | 1.00x(?) |
SortStringsUnicode | 9425 | 9436 | +0.1% | 1.00x(?) |
NopDeinit | 35678 | 35837 | +0.5% | 1.00x(?) |
ObjectiveCBridgeFromNSArrayAnyObject | 65436 | 65363 | -0.1% | 1.00x(?) |
ObjectiveCBridgeStubDataAppend | 2873 | 2860 | -0.5% | 1.00x(?) |
StringBuilder | 1529 | 1532 | +0.2% | 1.00x(?) |
MonteCarloE | 10001 | 10027 | +0.3% | 1.00x(?) |
DictionaryRemove | 5051 | 5069 | +0.4% | 1.00x(?) |
LinkedList | 6873 | 6853 | -0.3% | 1.00x(?) |
ArrayOfPOD | 172 | 172 | +0.0% | 1.00x |
BitCount | 1 | 1 | +0.0% | 1.00x |
ObjectiveCBridgeFromNSArrayAnyObjectToStringForced | 166916 | 166164 | -0.5% | 1.00x(?) |
StringWalk | 6165 | 6166 | +0.0% | 1.00x(?) |
ArrayValueProp | 5 | 5 | +0.0% | 1.00x |
GlobalClass | 0 | 0 | +0.0% | 1.00x |
Memset | 222 | 222 | +0.0% | 1.00x |
Dictionary2OfObjects | 3349 | 3336 | -0.4% | 1.00x(?) |
ArrayValueProp4 | 5 | 5 | +0.0% | 1.00x |
ArrayValueProp2 | 5 | 5 | +0.0% | 1.00x |
ArrayValueProp3 | 5 | 5 | +0.0% | 1.00x |
ObjectiveCBridgeFromNSDictionaryAnyObject | 246778 | 248534 | +0.7% | 0.99x(?) |
133 | 3703137 | 3757838 | +1.5% | 0.99x |
ObjectiveCBridgeStubFromNSStringRef | 124 | 125 | +0.8% | 0.99x(?) |
ObjectiveCBridgeStubFromNSString | 673 | 683 | +1.5% | 0.99x(?) |
ArrayLiteral | 998 | 1005 | +0.7% | 0.99x(?) |
Dictionary3 | 530 | 535 | +0.9% | 0.99x(?) |
Hanoi | 3339 | 3368 | +0.9% | 0.99x(?) |
ArrayInClass | 90 | 91 | +1.1% | 0.99x(?) |
StringHasSuffix | 788 | 797 | +1.1% | 0.99x |
ArrayAppend | 740 | 744 | +0.5% | 0.99x(?) |
StringHasPrefixUnicode | 15301 | 15488 | +1.2% | 0.99x(?) |
ObjectiveCBridgeFromNSSetAnyObjectToStringForced | 116994 | 117663 | +0.6% | 0.99x(?) |
ArrayAppendReserved | 521 | 526 | +1.0% | 0.99x(?) |
AngryPhonebook | 2852 | 2888 | +1.3% | 0.99x(?) |
StackPromo | 19187 | 19480 | +1.5% | 0.98x |
ObjectiveCBridgeFromNSDictionaryAnyObjectToString | 213738 | 217253 | +1.6% | 0.98x(?) |
ObjectiveCBridgeFromNSArrayAnyObjectToString | 162829 | 165625 | +1.7% | 0.98x(?) |
ObjectiveCBridgeStubFromNSDateRef | 3632 | 3691 | +1.6% | 0.98x |
Join | 448 | 455 | +1.6% | 0.98x(?) |
StaticArray | 2878 | 2945 | +2.3% | 0.98x(?) |
ArrayOfRef | 3501 | 3572 | +2.0% | 0.98x |
DictionaryOfObjects | 2220 | 2267 | +2.1% | 0.98x(?) |
StringEqualPointerComparison | 7328 | 7447 | +1.6% | 0.98x(?) |
Dictionary | 733 | 747 | +1.9% | 0.98x(?) |
HashTest | 1977 | 2018 | +2.1% | 0.98x(?) |
ObjectiveCBridgeFromNSSetAnyObjectForced | 4139 | 4228 | +2.1% | 0.98x(?) |
StrToInt | 4989 | 5108 | +2.4% | 0.98x(?) |
TwoSum | 1901 | 1947 | +2.4% | 0.98x(?) |
ObjectiveCBridgeStubFromNSDate | 3357 | 3437 | +2.4% | 0.98x(?) |
ObjectiveCBridgeStubURLAppendPath | 200549 | 206800 | +3.1% | 0.97x(?) |
NSDictionaryCastToSwift | 12952 | 13411 | +3.5% | 0.97x(?) |
ObjectiveCBridgeFromNSSetAnyObjectToString | 159794 | 164988 | +3.2% | 0.97x(?) |
ObjectiveCBridgeStubDateAccess | 175 | 181 | +3.4% | 0.97x(?) |
Chars | 660 | 681 | +3.2% | 0.97x |
ObjectiveCBridgeStubNSDateMutationRef | 12274 | 12699 | +3.5% | 0.97x(?) |
PopFrontArray | 1149 | 1201 | +4.5% | 0.96x(?) |
ObjectiveCBridgeStubToNSString | 1240 | 1290 | +4.0% | 0.96x(?) |
ObjectiveCBridgeToNSArray | 31985 | 33205 | +3.8% | 0.96x(?) |
Phonebook | 7408 | 7687 | +3.8% | 0.96x |
SetIsSubsetOf_OfObjects | 616 | 641 | +4.1% | 0.96x |
SevenBoom | 1346 | 1408 | +4.6% | 0.96x |
SetIntersect_OfObjects | 2357 | 2488 | +5.6% | 0.95x |
ObjectiveCBridgeStubToNSStringRef | 117 | 123 | +5.1% | 0.95x(?) |
ObjectiveCBridgeFromNSDictionaryAnyObjectToStringForced | 139340 | 146055 | +4.8% | 0.95x(?) |
SetIsSubsetOf | 487 | 514 | +5.5% | 0.95x |
ArrayOfGenericRef | 3500 | 3668 | +4.8% | 0.95x |
SetExclusiveOr_OfObjects | 8447 | 8937 | +5.8% | 0.95x |
Regression (3)
TEST | OLD_MIN | NEW_MIN | DELTA (%) | SPEEDUP |
---|---|---|---|---|
ArrayAppend | 3365 | 3730 | +10.8% | 0.90x(?) |
StringWalk | 47186 | 51074 | +8.2% | 0.92x |
ObjectiveCBridgeFromNSString | 4849 | 5223 | +7.7% | 0.93x(?) |
Improvement (2)
TEST | OLD_MIN | NEW_MIN | DELTA (%) | SPEEDUP |
---|---|---|---|---|
ArrayOfGenericPOD | 3704 | 3420 | -7.7% | 1.08x |
ObjectiveCBridgeFromNSStringForced | 2937 | 2663 | -9.3% | 1.10x |
No Changes (129)
TEST | OLD_MIN | NEW_MIN | DELTA (%) | SPEEDUP |
---|---|---|---|---|
PopFrontUnsafePointer | 261524 | 249780 | -4.5% | 1.05x(?) |
ObjectiveCBridgeFromNSArrayAnyObjectToStringForced | 178783 | 170065 | -4.9% | 1.05x(?) |
ObjectiveCBridgeToNSSet | 16539 | 15967 | -3.5% | 1.04x(?) |
ArrayValueProp3 | 2766 | 2670 | -3.5% | 1.04x(?) |
ObjectiveCBridgeFromNSArrayAnyObjectToString | 167720 | 163253 | -2.7% | 1.03x(?) |
DictionarySwapOfObjects | 26358 | 25617 | -2.8% | 1.03x(?) |
StringHasPrefixUnicode | 17400 | 16973 | -2.5% | 1.03x(?) |
Histogram | 14686 | 14336 | -2.4% | 1.02x |
SortStrings | 2639 | 2580 | -2.2% | 1.02x |
StringInterpolation | 16243 | 15874 | -2.3% | 1.02x(?) |
ProtocolDispatch | 5951 | 5833 | -2.0% | 1.02x(?) |
Dictionary2 | 5273 | 5160 | -2.1% | 1.02x(?) |
NSError | 691 | 675 | -2.3% | 1.02x |
PolymorphicCalls | 1215 | 1191 | -2.0% | 1.02x(?) |
SortStringsUnicode | 10348 | 10114 | -2.3% | 1.02x(?) |
ArrayOfPOD | 2392 | 2353 | -1.6% | 1.02x(?) |
StringBuilder | 2900 | 2855 | -1.6% | 1.02x(?) |
ObjectiveCBridgeStubFromArrayOfNSString | 112370 | 110699 | -1.5% | 1.02x(?) |
DictionarySwap | 11210 | 11119 | -0.8% | 1.01x(?) |
StrComplexWalk | 8408 | 8329 | -0.9% | 1.01x(?) |
ErrorHandling | 3867 | 3836 | -0.8% | 1.01x(?) |
ObjectiveCBridgeFromNSSetAnyObject | 119718 | 117991 | -1.4% | 1.01x(?) |
AngryPhonebook | 3778 | 3731 | -1.2% | 1.01x(?) |
PopFrontArrayGeneric | 11254 | 11191 | -0.6% | 1.01x(?) |
CaptureProp | 115733 | 114564 | -1.0% | 1.01x(?) |
MapReduce | 44990 | 44543 | -1.0% | 1.01x |
SetExclusiveOr | 46431 | 46096 | -0.7% | 1.01x(?) |
NSDictionaryCastToSwift | 14700 | 14589 | -0.8% | 1.01x(?) |
ObjectiveCBridgeStubNSDateRefAccess | 1290 | 1274 | -1.2% | 1.01x(?) |
ObjectiveCBridgeStubDateAccess | 1108 | 1100 | -0.7% | 1.01x(?) |
PopFrontArray | 24238 | 24015 | -0.9% | 1.01x(?) |
DictionaryRemove | 31325 | 31137 | -0.6% | 1.01x(?) |
ObjectiveCBridgeFromNSSetAnyObjectToString | 176488 | 174191 | -1.3% | 1.01x(?) |
Memset | 19875 | 19611 | -1.3% | 1.01x |
ObjectiveCBridgeStubFromNSDate | 3676 | 3647 | -0.8% | 1.01x(?) |
ArraySubscript | 5499 | 5503 | +0.1% | 1.00x(?) |
ObjectiveCBridgeToNSString | 1102 | 1100 | -0.2% | 1.00x(?) |
MonteCarloPi | 50941 | 50819 | -0.2% | 1.00x(?) |
ClassArrayGetter | 1260 | 1260 | +0.0% | 1.00x |
Array2D | 800101 | 802919 | +0.3% | 1.00x(?) |
DictionaryBridge | 3971 | 3963 | -0.2% | 1.00x(?) |
ObjectiveCBridgeStubFromNSDateRef | 4118 | 4116 | -0.1% | 1.00x(?) |
StringWithCString | 729979 | 730136 | +0.0% | 1.00x(?) |
ObjectiveCBridgeFromNSArrayAnyObjectForced | 7156 | 7176 | +0.3% | 1.00x(?) |
Prims | 14366 | 14435 | +0.5% | 1.00x(?) |
SortLettersInPlace | 2548 | 2539 | -0.3% | 1.00x(?) |
Dictionary3OfObjects | 2673 | 2674 | +0.0% | 1.00x(?) |
ByteSwap | 10 | 10 | +0.0% | 1.00x |
SuperChars | 529763 | 531635 | +0.3% | 1.00x(?) |
XorLoop | 18723 | 18675 | -0.3% | 1.00x(?) |
StaticArray | 27608 | 27600 | -0.0% | 1.00x(?) |
TypeFlood | 153 | 153 | +0.0% | 1.00x |
ProtocolDispatch2 | 439 | 437 | -0.5% | 1.00x(?) |
Dictionary3 | 2074 | 2077 | +0.1% | 1.00x(?) |
StringHasPrefix | 1515 | 1516 | +0.1% | 1.00x(?) |
SetIntersect_OfObjects | 19318 | 19223 | -0.5% | 1.00x(?) |
Join | 1469 | 1470 | +0.1% | 1.00x(?) |
ObjectiveCBridgeStubDateMutation | 447 | 447 | +0.0% | 1.00x |
DictionaryOfObjects | 5627 | 5647 | +0.4% | 1.00x(?) |
ObjectiveCBridgeStubToNSDateRef | 3245 | 3240 | -0.1% | 1.00x(?) |
StringEqualPointerComparison | 9637 | 9626 | -0.1% | 1.00x(?) |
RC4 | 8558 | 8567 | +0.1% | 1.00x(?) |
ObjectiveCBridgeStubToNSStringRef | 155 | 155 | +0.0% | 1.00x |
Calculator | 940 | 941 | +0.1% | 1.00x(?) |
Hanoi | 19723 | 19675 | -0.2% | 1.00x(?) |
DictionaryRemoveOfObjects | 61667 | 61533 | -0.2% | 1.00x(?) |
SetIsSubsetOf | 3057 | 3049 | -0.3% | 1.00x(?) |
Dictionary | 2811 | 2802 | -0.3% | 1.00x(?) |
NopDeinit | 56935 | 56746 | -0.3% | 1.00x(?) |
SetIntersect | 19465 | 19527 | +0.3% | 1.00x(?) |
ObjectiveCBridgeStubDataAppend | 3194 | 3206 | +0.4% | 1.00x(?) |
RGBHistogramOfObjects | 101195 | 101148 | -0.1% | 1.00x(?) |
Phonebook | 63674 | 63363 | -0.5% | 1.00x(?) |
Sim2DArray | 14027 | 13991 | -0.3% | 1.00x(?) |
SetExclusiveOr_OfObjects | 65454 | 65700 | +0.4% | 1.00x(?) |
MonteCarloE | 108049 | 107728 | -0.3% | 1.00x(?) |
SetUnion_OfObjects | 49374 | 49275 | -0.2% | 1.00x(?) |
StringHasSuffixUnicode | 66467 | 66242 | -0.3% | 1.00x(?) |
HashTest | 5473 | 5471 | -0.0% | 1.00x(?) |
SetIsSubsetOf_OfObjects | 2892 | 2906 | +0.5% | 1.00x(?) |
LinkedList | 26382 | 26398 | +0.1% | 1.00x(?) |
ObjectiveCBridgeFromNSSetAnyObjectForced | 7725 | 7750 | +0.3% | 1.00x(?) |
ArrayValueProp4 | 2717 | 2712 | -0.2% | 1.00x(?) |
Chars | 5311 | 5334 | +0.4% | 1.00x(?) |
DeadArray | 131453 | 131529 | +0.1% | 1.00x(?) |
GlobalClass | 0 | 0 | +0.0% | 1.00x |
StackPromo | 130118 | 131018 | +0.7% | 0.99x(?) |
RecursiveOwnedParameter | 7639 | 7681 | +0.6% | 0.99x(?) |
133 | 6564046 | 6658262 | +1.4% | 0.99x |
RangeAssignment | 23548 | 23668 | +0.5% | 0.99x(?) |
ObjectAllocation | 538 | 542 | +0.7% | 0.99x(?) |
Walsh | 12160 | 12254 | +0.8% | 0.99x(?) |
ArrayOfRef | 8990 | 9062 | +0.8% | 0.99x(?) |
ObjectiveCBridgeStubURLAppendPathRef | 209266 | 211117 | +0.9% | 0.99x(?) |
UTF8Decode | 42875 | 43226 | +0.8% | 0.99x |
ObjectiveCBridgeFromNSArrayAnyObject | 68361 | 69358 | +1.5% | 0.99x(?) |
StrToInt | 5465 | 5519 | +1.0% | 0.99x(?) |
ArrayInClass | 3674 | 3712 | +1.0% | 0.99x(?) |
ArrayOfGenericRef | 9573 | 9701 | +1.3% | 0.99x(?) |
StringHasSuffix | 1498 | 1512 | +0.9% | 0.99x(?) |
NSStringConversion | 2660 | 2693 | +1.2% | 0.99x(?) |
SetUnion | 31845 | 32132 | +0.9% | 0.99x(?) |
ObjectiveCBridgeStubNSDataAppend | 5135 | 5208 | +1.4% | 0.99x(?) |
BitCount | 91 | 92 | +1.1% | 0.99x(?) |
ArrayValueProp | 2255 | 2278 | +1.0% | 0.99x(?) |
Dictionary2OfObjects | 7044 | 7124 | +1.1% | 0.99x(?) |
ArrayAppendReserved | 3215 | 3232 | +0.5% | 0.99x(?) |
TwoSum | 9623 | 9698 | +0.8% | 0.99x(?) |
ArrayValueProp2 | 2818 | 2855 | +1.3% | 0.99x |
SevenBoom | 1488 | 1503 | +1.0% | 0.99x(?) |
Integrate | 358 | 367 | +2.5% | 0.98x(?) |
ObjectiveCBridgeStubToNSString | 1287 | 1316 | +2.2% | 0.98x(?) |
ObjectiveCBridgeStubFromNSStringRef | 163 | 166 | +1.8% | 0.98x(?) |
ObjectiveCBridgeToNSArray | 31667 | 32343 | +2.1% | 0.98x(?) |
DictionaryLiteral | 24667 | 25123 | +1.9% | 0.98x(?) |
ObjectiveCBridgeStubURLAppendPath | 196722 | 201033 | +2.2% | 0.98x(?) |
ObjectiveCBridgeFromNSDictionaryAnyObjectToStringForced | 143370 | 146743 | +2.4% | 0.98x(?) |
ObjectiveCBridgeStubToArrayOfNSString | 30537 | 31127 | +1.9% | 0.98x(?) |
ObjectiveCBridgeToNSDictionary | 16126 | 16382 | +1.6% | 0.98x |
RGBHistogram | 51762 | 52946 | +2.3% | 0.98x |
ArrayLiteral | 1076 | 1095 | +1.8% | 0.98x(?) |
ObjectiveCBridgeFromNSDictionaryAnyObject | 248576 | 256208 | +3.1% | 0.97x |
ObjectiveCBridgeStubNSDateMutationRef | 13945 | 14382 | +3.1% | 0.97x(?) |
ObjectiveCBridgeFromNSDictionaryAnyObjectToString | 219147 | 228696 | +4.4% | 0.96x(?) |
ObjectiveCBridgeFromNSDictionaryAnyObjectForced | 7193 | 7479 | +4.0% | 0.96x(?) |
ObjectiveCBridgeStubToNSDate | 13378 | 13902 | +3.9% | 0.96x(?) |
ObjectiveCBridgeFromNSSetAnyObjectToStringForced | 126534 | 131406 | +3.9% | 0.96x(?) |
ObjectiveCBridgeStubFromNSString | 677 | 715 | +5.6% | 0.95x(?) |
OpenClose | 433 | 456 | +5.3% | 0.95x(?) |
@swift-ci Please benchmark |
Build comment file:Optimized (O)
|
TEST | OLD_MIN | NEW_MIN | DELTA (%) | SPEEDUP |
---|---|---|---|---|
DictionaryLiteral | 4343 | 4761 | +9.6% | 0.91x |
Improvement (0)
No Changes (133)
TEST | OLD_MIN | NEW_MIN | DELTA (%) | SPEEDUP |
---|---|---|---|---|
SortStringsUnicode | 9493 | 9255 | -2.5% | 1.03x |
ObjectiveCBridgeStubNSDateMutationRef | 12504 | 12136 | -2.9% | 1.03x(?) |
ObjectiveCBridgeStubToNSDate | 13845 | 13517 | -2.4% | 1.02x(?) |
StringInterpolation | 11863 | 11667 | -1.6% | 1.02x |
ObjectiveCBridgeStubToNSString | 1330 | 1301 | -2.2% | 1.02x |
ObjectiveCBridgeStubFromNSString | 693 | 679 | -2.0% | 1.02x |
ObjectiveCBridgeFromNSSetAnyObject | 113810 | 111910 | -1.7% | 1.02x(?) |
DictionaryRemove | 5159 | 5060 | -1.9% | 1.02x(?) |
ObjectiveCBridgeStubFromArrayOfNSString | 114703 | 112360 | -2.0% | 1.02x(?) |
ObjectiveCBridgeFromNSStringForced | 2295 | 2283 | -0.5% | 1.01x(?) |
Prims | 779 | 775 | -0.5% | 1.01x(?) |
SuperChars | 503841 | 501310 | -0.5% | 1.01x(?) |
DictionarySwapOfObjects | 6912 | 6872 | -0.6% | 1.01x(?) |
Hanoi | 3476 | 3454 | -0.6% | 1.01x |
ObjectiveCBridgeFromNSArrayAnyObject | 66872 | 66329 | -0.8% | 1.01x(?) |
ObjectiveCBridgeStubDataAppend | 2870 | 2847 | -0.8% | 1.01x |
NSStringConversion | 628 | 624 | -0.6% | 1.01x(?) |
Dictionary2OfObjects | 3398 | 3373 | -0.7% | 1.01x |
ArraySubscript | 1424 | 1424 | +0.0% | 1.00x |
ObjectiveCBridgeToNSString | 1068 | 1072 | +0.4% | 1.00x |
MonteCarloPi | 45039 | 45043 | +0.0% | 1.00x(?) |
RecursiveOwnedParameter | 1939 | 1937 | -0.1% | 1.00x |
Integrate | 238 | 238 | +0.0% | 1.00x |
ObjectiveCBridgeFromNSDictionaryAnyObjectToString | 214201 | 215251 | +0.5% | 1.00x(?) |
ObjectiveCBridgeFromNSArrayAnyObjectToString | 168583 | 168835 | +0.1% | 1.00x(?) |
ClassArrayGetter | 12 | 12 | +0.0% | 1.00x |
Histogram | 682 | 681 | -0.1% | 1.00x |
SortStrings | 1839 | 1843 | +0.2% | 1.00x(?) |
ObjectiveCBridgeStubFromNSDateRef | 3686 | 3685 | -0.0% | 1.00x(?) |
ArrayOfGenericPOD | 220 | 220 | +0.0% | 1.00x |
StringWithCString | 622029 | 621640 | -0.1% | 1.00x(?) |
ObjectiveCBridgeFromNSArrayAnyObjectForced | 3853 | 3848 | -0.1% | 1.00x(?) |
SortLettersInPlace | 996 | 995 | -0.1% | 1.00x(?) |
DictionarySwap | 778 | 779 | +0.1% | 1.00x(?) |
PopFrontArray | 1150 | 1149 | -0.1% | 1.00x(?) |
Dictionary3OfObjects | 904 | 906 | +0.2% | 1.00x(?) |
RangeAssignment | 325 | 324 | -0.3% | 1.00x(?) |
StringHasPrefix | 670 | 670 | +0.0% | 1.00x |
ByteSwap | 1 | 1 | +0.0% | 1.00x |
XorLoop | 380 | 381 | +0.3% | 1.00x |
StaticArray | 2829 | 2829 | +0.0% | 1.00x |
ProtocolDispatch | 3039 | 3040 | +0.0% | 1.00x(?) |
ObjectAllocation | 149 | 149 | +0.0% | 1.00x |
TypeFlood | 0 | 0 | +0.0% | 1.00x |
AngryPhonebook | 2831 | 2840 | +0.3% | 1.00x(?) |
ProtocolDispatch2 | 156 | 156 | +0.0% | 1.00x |
Walsh | 322 | 322 | +0.0% | 1.00x |
Dictionary2 | 1953 | 1959 | +0.3% | 1.00x(?) |
SetIntersect_OfObjects | 2473 | 2483 | +0.4% | 1.00x |
Join | 474 | 476 | +0.4% | 1.00x |
ArrayAppend | 771 | 772 | +0.1% | 1.00x |
ObjectiveCBridgeStubDateMutation | 273 | 273 | +0.0% | 1.00x |
ObjectiveCBridgeToNSArray | 31722 | 31751 | +0.1% | 1.00x(?) |
NSError | 337 | 337 | +0.0% | 1.00x |
PopFrontArrayGeneric | 1146 | 1146 | +0.0% | 1.00x |
PopFrontUnsafePointer | 9408 | 9405 | -0.0% | 1.00x(?) |
StringEqualPointerComparison | 7253 | 7259 | +0.1% | 1.00x(?) |
CaptureProp | 4263 | 4261 | -0.1% | 1.00x |
PolymorphicCalls | 62 | 62 | +0.0% | 1.00x |
RC4 | 257 | 257 | +0.0% | 1.00x |
ObjectiveCBridgeStubToNSStringRef | 124 | 124 | +0.0% | 1.00x |
Calculator | 35 | 35 | +0.0% | 1.00x |
MapReduce | 374 | 373 | -0.3% | 1.00x |
OpenClose | 51 | 51 | +0.0% | 1.00x |
DictionaryRemoveOfObjects | 20600 | 20622 | +0.1% | 1.00x(?) |
UTF8Decode | 322 | 322 | +0.0% | 1.00x |
ObjectiveCBridgeStubURLAppendPath | 196674 | 195746 | -0.5% | 1.00x(?) |
ObjectiveCBridgeFromNSDictionaryAnyObjectToStringForced | 135523 | 135474 | -0.0% | 1.00x(?) |
SetIsSubsetOf | 516 | 515 | -0.2% | 1.00x |
Dictionary | 777 | 778 | +0.1% | 1.00x(?) |
NopDeinit | 36685 | 36680 | -0.0% | 1.00x(?) |
SetIntersect | 1198 | 1195 | -0.2% | 1.00x(?) |
SetExclusiveOr | 3890 | 3904 | +0.4% | 1.00x |
ObjectiveCBridgeFromNSSetAnyObjectToString | 165259 | 165020 | -0.1% | 1.00x(?) |
ObjectiveCBridgeStubNSDateRefAccess | 338 | 338 | +0.0% | 1.00x |
Phonebook | 7626 | 7626 | +0.0% | 1.00x |
ObjectiveCBridgeStubDateAccess | 182 | 182 | +0.0% | 1.00x |
Sim2DArray | 385 | 384 | -0.3% | 1.00x |
MonteCarloE | 10591 | 10590 | -0.0% | 1.00x(?) |
StringHasSuffixUnicode | 65484 | 65201 | -0.4% | 1.00x |
HashTest | 2049 | 2047 | -0.1% | 1.00x(?) |
SetIsSubsetOf_OfObjects | 653 | 652 | -0.1% | 1.00x(?) |
ObjectiveCBridgeToNSSet | 16531 | 16536 | +0.0% | 1.00x(?) |
LinkedList | 7278 | 7255 | -0.3% | 1.00x(?) |
ObjectiveCBridgeFromNSSetAnyObjectToStringForced | 118357 | 118163 | -0.2% | 1.00x(?) |
ArrayValueProp4 | 6 | 6 | +0.0% | 1.00x |
ArrayOfPOD | 182 | 182 | +0.0% | 1.00x |
Chars | 674 | 673 | -0.1% | 1.00x(?) |
133 | 3730653 | 3731697 | +0.0% | 1.00x |
StringBuilder | 1587 | 1587 | +0.0% | 1.00x |
DeadArray | 185 | 185 | +0.0% | 1.00x |
ArrayValueProp2 | 6 | 6 | +0.0% | 1.00x |
BitCount | 1 | 1 | +0.0% | 1.00x |
ArrayLiteral | 1024 | 1022 | -0.2% | 1.00x(?) |
SevenBoom | 1366 | 1362 | -0.3% | 1.00x(?) |
StringWalk | 6272 | 6267 | -0.1% | 1.00x(?) |
ArrayValueProp | 6 | 6 | +0.0% | 1.00x |
ObjectiveCBridgeFromNSString | 1617 | 1614 | -0.2% | 1.00x |
GlobalClass | 0 | 0 | +0.0% | 1.00x |
Memset | 235 | 236 | +0.4% | 1.00x |
ArrayAppendReserved | 536 | 535 | -0.2% | 1.00x(?) |
ArrayValueProp3 | 6 | 6 | +0.0% | 1.00x |
ObjectiveCBridgeStubFromNSDate | 3383 | 3380 | -0.1% | 1.00x(?) |
StackPromo | 19986 | 20119 | +0.7% | 0.99x(?) |
Array2D | 2025 | 2043 | +0.9% | 0.99x(?) |
ObjectiveCBridgeFromNSDictionaryAnyObjectForced | 4744 | 4771 | +0.6% | 0.99x(?) |
ErrorHandling | 3069 | 3085 | +0.5% | 0.99x(?) |
ObjectiveCBridgeStubFromNSStringRef | 134 | 135 | +0.8% | 0.99x |
Dictionary3 | 546 | 549 | +0.6% | 0.99x |
StrComplexWalk | 3199 | 3235 | +1.1% | 0.99x |
ObjectiveCBridgeStubURLAppendPathRef | 201964 | 203418 | +0.7% | 0.99x(?) |
DictionaryOfObjects | 2287 | 2300 | +0.6% | 0.99x |
ObjectiveCBridgeStubToNSDateRef | 3380 | 3423 | +1.3% | 0.99x(?) |
ObjectiveCBridgeStubToArrayOfNSString | 31183 | 31379 | +0.6% | 0.99x(?) |
ArrayInClass | 91 | 92 | +1.1% | 0.99x |
ArrayOfGenericRef | 3606 | 3652 | +1.3% | 0.99x |
SetExclusiveOr_OfObjects | 8754 | 8858 | +1.2% | 0.99x |
ObjectiveCBridgeToNSDictionary | 16794 | 16993 | +1.2% | 0.99x(?) |
SetUnion_OfObjects | 7380 | 7468 | +1.2% | 0.99x |
StringHasPrefixUnicode | 15454 | 15671 | +1.4% | 0.99x(?) |
RGBHistogramOfObjects | 22696 | 22879 | +0.8% | 0.99x |
RGBHistogram | 3168 | 3185 | +0.5% | 0.99x(?) |
ObjectiveCBridgeFromNSSetAnyObjectForced | 4158 | 4179 | +0.5% | 0.99x(?) |
SetUnion | 3415 | 3448 | +1.0% | 0.99x(?) |
ObjectiveCBridgeFromNSArrayAnyObjectToStringForced | 166545 | 168463 | +1.1% | 0.99x(?) |
ObjectiveCBridgeStubNSDataAppend | 2376 | 2394 | +0.8% | 0.99x |
ObjectiveCBridgeFromNSDictionaryAnyObject | 243845 | 249868 | +2.5% | 0.98x(?) |
DictionaryBridge | 3870 | 3935 | +1.7% | 0.98x(?) |
ArrayOfRef | 3539 | 3597 | +1.6% | 0.98x |
StrToInt | 5030 | 5149 | +2.4% | 0.98x |
StringHasSuffix | 792 | 807 | +1.9% | 0.98x(?) |
TwoSum | 1959 | 1992 | +1.7% | 0.98x |
NSDictionaryCastToSwift | 13104 | 13638 | +4.1% | 0.96x(?) |
Regression (2)
TEST | OLD_MIN | NEW_MIN | DELTA (%) | SPEEDUP |
---|---|---|---|---|
TypeFlood | 154 | 165 | +7.1% | 0.93x |
StringWalk | 48900 | 52626 | +7.6% | 0.93x |
Improvement (0)
No Changes (132)
TEST | OLD_MIN | NEW_MIN | DELTA (%) | SPEEDUP |
---|---|---|---|---|
ArrayOfGenericPOD | 3707 | 3524 | -4.9% | 1.05x |
ObjectiveCBridgeStubFromArrayOfNSString | 116833 | 111750 | -4.3% | 1.05x(?) |
ArrayOfPOD | 2455 | 2367 | -3.6% | 1.04x |
ObjectiveCBridgeFromNSDictionaryAnyObjectToString | 227269 | 221173 | -2.7% | 1.03x(?) |
SortStringsUnicode | 10568 | 10290 | -2.6% | 1.03x |
SortStrings | 2695 | 2642 | -2.0% | 1.02x |
ObjectiveCBridgeStubFromNSString | 724 | 708 | -2.2% | 1.02x |
ObjectiveCBridgeStubURLAppendPathRef | 210035 | 206326 | -1.8% | 1.02x |
CaptureProp | 117746 | 115533 | -1.9% | 1.02x |
OpenClose | 437 | 428 | -2.1% | 1.02x(?) |
StringHasPrefixUnicode | 17443 | 17027 | -2.4% | 1.02x |
StringBuilder | 2955 | 2898 | -1.9% | 1.02x(?) |
ObjectiveCBridgeFromNSArrayAnyObjectToString | 168681 | 166613 | -1.2% | 1.01x(?) |
DictionaryBridge | 4029 | 3971 | -1.4% | 1.01x(?) |
ObjectiveCBridgeFromNSStringForced | 2720 | 2685 | -1.3% | 1.01x |
StringInterpolation | 16445 | 16354 | -0.6% | 1.01x(?) |
ObjectiveCBridgeStubFromNSStringRef | 170 | 169 | -0.6% | 1.01x |
ObjectAllocation | 551 | 548 | -0.5% | 1.01x(?) |
StringHasSuffixUnicode | 67055 | 66499 | -0.8% | 1.01x |
Dictionary3 | 2157 | 2141 | -0.7% | 1.01x(?) |
Calculator | 980 | 975 | -0.5% | 1.01x |
SetIsSubsetOf | 3171 | 3138 | -1.0% | 1.01x(?) |
PopFrontArray | 24858 | 24693 | -0.7% | 1.01x(?) |
ObjectiveCBridgeFromNSSetAnyObjectToStringForced | 134984 | 133545 | -1.1% | 1.01x(?) |
NSStringConversion | 2743 | 2704 | -1.4% | 1.01x(?) |
ObjectiveCBridgeStubNSDataAppend | 5366 | 5335 | -0.6% | 1.01x |
BitCount | 92 | 91 | -1.1% | 1.01x |
SevenBoom | 1524 | 1516 | -0.5% | 1.01x(?) |
ObjectiveCBridgeFromNSArrayAnyObjectToStringForced | 170946 | 169339 | -0.9% | 1.01x(?) |
ObjectiveCBridgeStubFromNSDate | 3748 | 3728 | -0.5% | 1.01x(?) |
ArraySubscript | 5783 | 5769 | -0.2% | 1.00x(?) |
ObjectiveCBridgeToNSString | 1111 | 1112 | +0.1% | 1.00x(?) |
DictionarySwapOfObjects | 26592 | 26595 | +0.0% | 1.00x(?) |
StackPromo | 129868 | 129372 | -0.4% | 1.00x(?) |
RecursiveOwnedParameter | 8086 | 8085 | -0.0% | 1.00x(?) |
ObjectiveCBridgeStubToNSString | 1361 | 1357 | -0.3% | 1.00x |
ClassArrayGetter | 1335 | 1333 | -0.1% | 1.00x(?) |
Array2D | 842749 | 844172 | +0.2% | 1.00x(?) |
Histogram | 14704 | 14634 | -0.5% | 1.00x(?) |
ObjectiveCBridgeFromNSDictionaryAnyObjectForced | 7348 | 7337 | -0.1% | 1.00x(?) |
MonteCarloPi | 53620 | 53620 | +0.0% | 1.00x |
StringWithCString | 773537 | 773680 | +0.0% | 1.00x(?) |
ObjectiveCBridgeFromNSArrayAnyObjectForced | 7378 | 7347 | -0.4% | 1.00x(?) |
Prims | 15057 | 15107 | +0.3% | 1.00x(?) |
SortLettersInPlace | 2635 | 2627 | -0.3% | 1.00x(?) |
DictionarySwap | 11540 | 11502 | -0.3% | 1.00x |
ObjectiveCBridgeFromNSString | 4895 | 4871 | -0.5% | 1.00x(?) |
133 | 6654382 | 6624190 | -0.5% | 1.00x |
Dictionary3OfObjects | 2796 | 2808 | +0.4% | 1.00x(?) |
RangeAssignment | 24186 | 24145 | -0.2% | 1.00x(?) |
StringHasPrefix | 1546 | 1548 | +0.1% | 1.00x |
ByteSwap | 10 | 10 | +0.0% | 1.00x |
SuperChars | 555361 | 554918 | -0.1% | 1.00x(?) |
XorLoop | 19635 | 19632 | -0.0% | 1.00x(?) |
Integrate | 362 | 362 | +0.0% | 1.00x |
Join | 1537 | 1544 | +0.5% | 1.00x |
ProtocolDispatch | 5832 | 5848 | +0.3% | 1.00x(?) |
AngryPhonebook | 3898 | 3889 | -0.2% | 1.00x(?) |
ProtocolDispatch2 | 442 | 442 | +0.0% | 1.00x |
HashTest | 5648 | 5649 | +0.0% | 1.00x(?) |
StrComplexWalk | 8367 | 8379 | +0.1% | 1.00x(?) |
SetIntersect_OfObjects | 20087 | 20106 | +0.1% | 1.00x(?) |
ErrorHandling | 3930 | 3928 | -0.1% | 1.00x(?) |
ArrayOfRef | 9349 | 9393 | +0.5% | 1.00x(?) |
ObjectiveCBridgeStubDateMutation | 435 | 434 | -0.2% | 1.00x |
DictionaryOfObjects | 5781 | 5806 | +0.4% | 1.00x |
PopFrontUnsafePointer | 258666 | 258779 | +0.0% | 1.00x(?) |
StringEqualPointerComparison | 9639 | 9685 | +0.5% | 1.00x(?) |
PolymorphicCalls | 1184 | 1186 | +0.2% | 1.00x(?) |
ObjectiveCBridgeStubToNSStringRef | 165 | 165 | +0.0% | 1.00x |
MapReduce | 46723 | 46767 | +0.1% | 1.00x(?) |
DictionaryRemoveOfObjects | 64192 | 64272 | +0.1% | 1.00x(?) |
UTF8Decode | 45144 | 45092 | -0.1% | 1.00x |
ObjectiveCBridgeStubURLAppendPath | 198268 | 198046 | -0.1% | 1.00x(?) |
ObjectiveCBridgeFromNSDictionaryAnyObjectToStringForced | 142681 | 142566 | -0.1% | 1.00x(?) |
Dictionary | 2875 | 2871 | -0.1% | 1.00x |
NopDeinit | 56716 | 56688 | -0.1% | 1.00x(?) |
ObjectiveCBridgeStubToArrayOfNSString | 31255 | 31219 | -0.1% | 1.00x(?) |
ObjectiveCBridgeFromNSArrayAnyObject | 71054 | 71030 | -0.0% | 1.00x(?) |
SetIntersect | 20102 | 20053 | -0.2% | 1.00x(?) |
SetExclusiveOr | 48120 | 48271 | +0.3% | 1.00x(?) |
NSDictionaryCastToSwift | 14731 | 14756 | +0.2% | 1.00x(?) |
ObjectiveCBridgeStubNSDateRefAccess | 1269 | 1270 | +0.1% | 1.00x(?) |
StrToInt | 5498 | 5507 | +0.2% | 1.00x |
ArrayInClass | 4019 | 4015 | -0.1% | 1.00x(?) |
StringHasSuffix | 1494 | 1491 | -0.2% | 1.00x(?) |
Phonebook | 63065 | 63081 | +0.0% | 1.00x(?) |
ObjectiveCBridgeStubDateAccess | 1095 | 1095 | +0.0% | 1.00x |
Sim2DArray | 14614 | 14618 | +0.0% | 1.00x(?) |
SetExclusiveOr_OfObjects | 69023 | 68941 | -0.1% | 1.00x(?) |
MonteCarloE | 112627 | 112334 | -0.3% | 1.00x |
SetUnion_OfObjects | 52029 | 51993 | -0.1% | 1.00x(?) |
RC4 | 8978 | 8985 | +0.1% | 1.00x(?) |
Walsh | 12785 | 12812 | +0.2% | 1.00x |
SetIsSubsetOf_OfObjects | 3024 | 3024 | +0.0% | 1.00x |
ArrayAppend | 3324 | 3326 | +0.1% | 1.00x(?) |
LinkedList | 27996 | 27958 | -0.1% | 1.00x(?) |
RGBHistogramOfObjects | 105126 | 104805 | -0.3% | 1.00x |
RGBHistogram | 53591 | 53666 | +0.1% | 1.00x(?) |
ObjectiveCBridgeFromNSSetAnyObjectForced | 7732 | 7716 | -0.2% | 1.00x(?) |
ArrayValueProp4 | 2731 | 2729 | -0.1% | 1.00x(?) |
SetUnion | 33599 | 33477 | -0.4% | 1.00x(?) |
ArrayLiteral | 1111 | 1109 | -0.2% | 1.00x(?) |
ArrayValueProp | 2308 | 2313 | +0.2% | 1.00x(?) |
GlobalClass | 0 | 0 | +0.0% | 1.00x |
Memset | 20652 | 20667 | +0.1% | 1.00x |
Dictionary2OfObjects | 7242 | 7254 | +0.2% | 1.00x(?) |
ArrayAppendReserved | 3190 | 3192 | +0.1% | 1.00x |
TwoSum | 9968 | 10007 | +0.4% | 1.00x(?) |
ArrayValueProp2 | 2874 | 2867 | -0.2% | 1.00x |
ArrayValueProp3 | 2782 | 2788 | +0.2% | 1.00x(?) |
ObjectiveCBridgeStubFromNSDateRef | 4136 | 4160 | +0.6% | 0.99x(?) |
StaticArray | 27477 | 27792 | +1.1% | 0.99x(?) |
ObjectiveCBridgeFromNSSetAnyObject | 117704 | 118989 | +1.1% | 0.99x |
Dictionary2 | 5357 | 5403 | +0.9% | 0.99x |
ObjectiveCBridgeToNSArray | 31659 | 31978 | +1.0% | 0.99x(?) |
ObjectiveCBridgeStubToNSDateRef | 3356 | 3379 | +0.7% | 0.99x(?) |
Hanoi | 20202 | 20331 | +0.6% | 0.99x |
ArrayOfGenericRef | 9987 | 10076 | +0.9% | 0.99x(?) |
DictionaryRemove | 32255 | 32443 | +0.6% | 0.99x |
ObjectiveCBridgeStubNSDateMutationRef | 14214 | 14325 | +0.8% | 0.99x(?) |
ObjectiveCBridgeFromNSDictionaryAnyObject | 255579 | 260792 | +2.0% | 0.98x |
ObjectiveCBridgeStubToNSDate | 13740 | 13978 | +1.7% | 0.98x(?) |
ObjectiveCBridgeToNSSet | 16267 | 16532 | +1.6% | 0.98x(?) |
NSError | 676 | 689 | +1.9% | 0.98x(?) |
PopFrontArrayGeneric | 11449 | 11637 | +1.6% | 0.98x |
DictionaryLiteral | 24787 | 25352 | +2.3% | 0.98x |
ObjectiveCBridgeStubDataAppend | 3210 | 3277 | +2.1% | 0.98x |
ObjectiveCBridgeToNSDictionary | 16867 | 17180 | +1.9% | 0.98x(?) |
Chars | 5338 | 5428 | +1.7% | 0.98x |
ObjectiveCBridgeFromNSSetAnyObjectToString | 173559 | 179132 | +3.2% | 0.97x(?) |
DeadArray | 129451 | 134152 | +3.6% | 0.96x(?) |
e00924c
to
640df7e
Compare
@swift-ci Please test |
@@ -313,71 +304,25 @@ void swift_MagicMirrorData_summary(const Metadata *T, String *result) { | |||
return swift_getObjCClassMetadata(isa); | |||
} | |||
|
|||
static std::tuple<const _ReflectableWitnessTable *, const Metadata *, | |||
const OpaqueValue *> | |||
static std::tuple<const Metadata *, const OpaqueValue *> | |||
getReflectableConformance(const Metadata *T, const OpaqueValue *Value) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name of this function no longer makes sense. How about just unwrapExistential()?
Looks good, other than potentially renaming the function. |
640df7e
to
ef557a1
Compare
@slavapestov Thank you for the review, I renamed the function. |
@swift-ci Please test and merge |
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.