Skip to content

Conversation

kubamracek
Copy link
Contributor

No description provided.

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please get @mikeash to also look at it before merging.

CMakeLists.txt Outdated
@@ -406,6 +406,10 @@ option(SWIFT_ENABLE_EXPERIMENTAL_CONCURRENCY
"Enable experimental Swift concurrency model"
FALSE)

option(SWIFT_ENABLE_COMPATIBILITY_OVERRIDES
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be specific to the stdlib would you mind just moving this to stdlib/CMakeLists.txt please?

@kubamracek
Copy link
Contributor Author

@swift-ci please test

1 similar comment
@kubamracek
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 31f9f2b23e9acc70faceb032de3767f19b0822f0

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 31f9f2b23e9acc70faceb032de3767f19b0822f0

@kubamracek kubamracek force-pushed the minimal-stdlib-no-compat-overrides branch from 1d16ad3 to fd7b186 Compare August 14, 2020 16:20
@kubamracek
Copy link
Contributor Author

@swift-ci please test

1 similar comment
@kubamracek
Copy link
Contributor Author

@swift-ci please test

@kubamracek kubamracek merged commit aa92419 into swiftlang:master Aug 15, 2020
@kubamracek kubamracek deleted the minimal-stdlib-no-compat-overrides branch August 15, 2020 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants