Skip to content

IRGen: Store scalars as bytes to avoid undefined bits #33485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2020

Conversation

aschwaighofer
Copy link
Contributor

Don't tempt llvm to misbehave on partially initialized bytes -- it will.

rdar:///66701259

Don't tempt llvm to misbehave on partially initialized bytes -- it will.

rdar:///66701259
@aschwaighofer
Copy link
Contributor Author

@swift-ci Please test

@aschwaighofer aschwaighofer requested a review from jckarter August 17, 2020 13:37
Copy link
Contributor

@jckarter jckarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@aschwaighofer aschwaighofer merged commit 7b1a43b into master Aug 17, 2020
@aschwaighofer aschwaighofer deleted the irgen_store_bits_as_bytes branch August 17, 2020 19:02
@davezarzycki
Copy link
Contributor

Do you have an LLVM bug tracking the "misbehavior"? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants